Skip to content

Commit a629d9f

Browse files
Remove tombstone comments for deleted methods
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent da56aa8 commit a629d9f

File tree

2 files changed

+0
-50
lines changed

2 files changed

+0
-50
lines changed

src/array_partition.jl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -223,10 +223,6 @@ end
223223
end
224224
end
225225
Base.filter(f, A::ArrayPartition) = ArrayPartition(map(x -> filter(f, x), A.x))
226-
# Optimized any/all for ArrayPartition (partition-level short-circuiting) moved to
227-
# RecursiveArrayTools.ShorthandConstructors to avoid invalidations (779 children).
228-
# The AbstractArray default any/all works correctly, just without partition-level optimization.
229-
# `using RecursiveArrayTools.ShorthandConstructors` to enable the optimized versions.
230226

231227
for type in [AbstractArray, PermutedDimsArray]
232228
@eval function Base.copyto!(dest::$(type), A::ArrayPartition)
@@ -744,5 +740,3 @@ ODEProblem(func, AP[ [1.,2.,3.], [1. 2.;3. 4.] ], (0, 1)) |> solve
744740
745741
"""
746742
struct AP end
747-
# AP[...] shorthand moved to RecursiveArrayTools.ShorthandConstructors to avoid invalidations.
748-
# `using RecursiveArrayTools.ShorthandConstructors` to enable.

src/vector_of_array.jl

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ function Base.Array{U}(VA::AbstractVectorOfArray{T, N}) where {U, T, N}
203203
end
204204
end
205205

206-
# AbstractVectorOfArray is already an AbstractArray, so convert is identity
207206

208207
function Adapt.adapt_structure(to, VA::AbstractVectorOfArray)
209208
return VectorOfArray(Adapt.adapt.((to,), VA.u))
@@ -506,7 +505,6 @@ end
506505

507506
Base.IndexStyle(::Type{<:AbstractVectorOfArray}) = IndexCartesian()
508507

509-
## lastindex inherited from AbstractArray (uses size)
510508

511509
## Linear indexing: convert to Cartesian and dispatch to the N-ary getindex
512510
Base.@propagate_inbounds function Base.getindex(A::AbstractVectorOfArray{T, N}, i::Int) where {T, N}
@@ -527,7 +525,6 @@ Base.@propagate_inbounds function Base.setindex!(A::AbstractVectorOfArray{T, N},
527525
return @inbounds A[ci] = v
528526
end
529527

530-
## RaggedEnd/RaggedRange types removed — lastindex now returns plain Ints from AbstractArray
531528

532529
Base.@propagate_inbounds function _getindex(
533530
A::AbstractVectorOfArray{T, N}, ::NotSymbolic, ::Colon, I::Int
@@ -690,7 +687,6 @@ Base.@propagate_inbounds function _getindex(
690687
return getindex(A, all_variable_symbols(A), args...)
691688
end
692689

693-
## RaggedEnd/RaggedRange resolution machinery removed — lastindex returns plain Ints now
694690

695691
# CartesianIndex with more dimensions than ndims(A) — for heterogeneous inner arrays
696692
# where (inner_indices..., column_index) may have more entries than ndims(A)
@@ -756,7 +752,6 @@ Base.@propagate_inbounds function Base.getindex(A::AbstractVectorOfArray, _arg,
756752
end
757753
end
758754

759-
## Adjoint getindex inherited from AbstractArray (Adjoint <: AbstractMatrix)
760755

761756
function _observed(A::AbstractDiffEqArray{T, N}, sym, i::Int) where {T, N}
762757
return observed(A, sym)(A.u[i], A.p, A.t[i])
@@ -775,7 +770,6 @@ Base.@propagate_inbounds function Base.setindex!(
775770
return VA.u[I] = v
776771
end
777772

778-
## Single-Int setindex! is now handled by the N-ary method via AbstractArray linear indexing
779773

780774
Base.@propagate_inbounds function Base.setindex!(
781775
VA::AbstractVectorOfArray{T, N}, v,
@@ -784,7 +778,6 @@ Base.@propagate_inbounds function Base.setindex!(
784778
return VA.u[I] = v
785779
end
786780

787-
## Colon setindex! for single arg removed - use VA[:, :] = v or VA.u[:] = v
788781

789782
Base.@propagate_inbounds function Base.setindex!(
790783
VA::AbstractVectorOfArray{T, N}, v,
@@ -793,7 +786,6 @@ Base.@propagate_inbounds function Base.setindex!(
793786
return VA.u[I] = v
794787
end
795788

796-
## AbstractArray{Int} setindex! for single arg removed - use VA[:, I] = v or VA.u[I] = v
797789

798790
Base.@propagate_inbounds function Base.setindex!(
799791
VA::AbstractVectorOfArray{T, N}, v, i::Int,
@@ -804,7 +796,6 @@ Base.@propagate_inbounds function Base.setindex!(
804796
end
805797
return v
806798
end
807-
## CartesianIndex setindex! handled by AbstractArray flattening to Int... method
808799

809800
Base.@propagate_inbounds function Base.setindex!(
810801
VA::AbstractVectorOfArray{T, N},
@@ -832,7 +823,6 @@ end
832823
end
833824
return (leading..., length(VA.u))
834825
end
835-
## Adjoint size inherited from LinearAlgebra (Adjoint <: AbstractMatrix)
836826

837827
Base.@propagate_inbounds function Base.setindex!(
838828
VA::AbstractVectorOfArray{T, N}, v,
@@ -877,7 +867,6 @@ function Base.:(==)(A::AbstractVectorOfArray, B::AbstractVectorOfArray)
877867
end
878868
# Comparison with plain arrays uses AbstractArray element-wise comparison via default
879869

880-
# Iteration is inherited from AbstractArray (iterates over elements in linear order)
881870
tuples(VA::DiffEqArray) = tuple.(VA.t, VA.u)
882871

883872
# Growing the array simply adds to the container vector
@@ -978,10 +967,7 @@ function Base.view(A::AbstractVectorOfArray, I::Vararg{Any, M}) where {M}
978967
@boundscheck checkbounds(A, J...)
979968
return SubArray(A, J)
980969
end
981-
## SubArray constructor inherited from AbstractArray
982-
## isassigned, ndims, eltype, check_parent_index_match inherited from AbstractArray
983970

984-
## checkbounds inherited from AbstractArray (uses axes derived from size)
985971
function Base.copyto!(
986972
dest::AbstractVectorOfArray{T, N},
987973
src::AbstractVectorOfArray{T2, N}
@@ -1014,16 +1000,8 @@ function Base.copyto!(
10141000
copyto!(dest.u, src)
10151001
return dest
10161002
end
1017-
## maybeview inherited from AbstractArray
1018-
1019-
## isapprox inherited from AbstractArray
1020-
1021-
## Arithmetic (+, -, *, /) inherited from AbstractArray / broadcasting
1022-
1023-
## CartesianIndices inherited from AbstractArray (uses axes/size)
10241003

10251004
# Tools for creating similar objects
1026-
# eltype is inherited from AbstractArray{T, N}
10271005

10281006
# similar(VA) - same type and size
10291007
function Base.similar(
@@ -1065,7 +1043,6 @@ end
10651043
return similar(Array{T}, dims)
10661044
end
10671045

1068-
## similar(VA, dims) inherited from AbstractArray (returns Array)
10691046

10701047
# fill!
10711048
# For DiffEqArray it ignores ts and fills only u
@@ -1084,20 +1061,8 @@ function Base.fill!(VA::AbstractVectorOfArray, x)
10841061
end
10851062
return VA
10861063
end
1087-
1088-
## reshape inherited from AbstractArray
1089-
1090-
# any/all inherited from AbstractArray (iterates over all elements including ragged zeros)
1091-
10921064
# conversion tools
10931065
vecarr_to_vectors(VA::AbstractVectorOfArray) = [VA[i, :] for i in eachindex(VA.u[1])]
1094-
## vec inherited from AbstractArray
1095-
## convert(Array, VA) inherited from AbstractArray (calls Array(VA))
1096-
1097-
# sum, prod inherited from AbstractArray
1098-
1099-
## adjoint inherited from AbstractArray
1100-
11011066
# linear algebra
11021067
ArrayInterface.issingular(va::AbstractVectorOfArray) = ArrayInterface.issingular(Matrix(va))
11031068

@@ -1127,12 +1092,6 @@ end
11271092
@recipe function f(VA::DiffEqArray{T, 1}) where {T}
11281093
VA.t, VA.u
11291094
end
1130-
1131-
# map is inherited from AbstractArray (maps over elements)
1132-
# To map over inner arrays, use `map(f, A.u)`
1133-
1134-
## mapreduce inherited from AbstractArray
1135-
11361095
## broadcasting
11371096

11381097
struct VectorOfArrayStyle{N} <: Broadcast.AbstractArrayStyle{N} end # N is only used when voa sees other abstract arrays
@@ -1162,7 +1121,6 @@ end
11621121
function Broadcast.BroadcastStyle(::Type{<:AbstractVectorOfArray{T, N}}) where {T, N}
11631122
return VectorOfArrayStyle{N}()
11641123
end
1165-
## broadcastable inherited from AbstractArray
11661124

11671125
# recurse through broadcast arguments and return a parent array for
11681126
# the first VoA or DiffEqArray in the bc arguments
@@ -1306,5 +1264,3 @@ nested = VA[
13061264
13071265
"""
13081266
struct VA end
1309-
# VA[...] shorthand moved to RecursiveArrayTools.ShorthandConstructors to avoid invalidations.
1310-
# `using RecursiveArrayTools.ShorthandConstructors` to enable.

0 commit comments

Comments
 (0)