Skip to content

Commit d19e184

Browse files
fix: correct root test env — drop ShorthandConstructors [sources] and downstream-only NLsolve
The branch had added RecursiveArrayToolsShorthandConstructors to the umbrella root [sources]. It is a test-only dependency (the VA[]/AP[] shorthand tests), not a dependency of the RecursiveArrayTools package itself, so sourcing it at the package level makes Pkg.test add it to the Core test env as a declared package dependency. Aqua.test_stale_deps then flags it as a stale dep of RecursiveArrayTools (the module never imports it), failing the QA group. master never had this [sources] entry: its runtests.jl Pkg.develops the sublibrary into the test env directly, which the current runtests.jl still does. Removing the [sources] entry restores master's green QA behavior (verified: Core+QA Pkg.test now passes — Quality Assurance 9 pass / 1 broken (expected ambiguities @test_broken) / 0 fail; previously 1 fail). Also drop NLsolve from the main [extras]/[targets].test/[compat]: it is used only by test/downstream/odesolve.jl and is already declared in test/downstream/Project.toml, so it does not belong in the base test env. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent d592b77 commit d19e184

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

Project.toml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ RecursiveArrayToolsTablesExt = ["Tables"]
4848
RecursiveArrayToolsTrackerExt = "Tracker"
4949
RecursiveArrayToolsZygoteExt = "Zygote"
5050

51-
[sources]
52-
RecursiveArrayToolsShorthandConstructors = {path = "lib/RecursiveArrayToolsShorthandConstructors"}
53-
5451
[compat]
5552
Adapt = "4"
5653
ArrayInterface = "7.17.0"
@@ -64,7 +61,6 @@ LinearAlgebra = "1.10"
6461
Measurements = "2.11"
6562
MonteCarloMeasurements = "1.2"
6663
Mooncake = "0.5"
67-
NLsolve = "4.5"
6864
Pkg = "1"
6965
Polyester = "0.7.16"
7066
PrecompileTools = "1.2.1"
@@ -93,7 +89,6 @@ KernelAbstractions = "63c18a36-062a-441e-b654-da1e3ab1ce7c"
9389
Measurements = "eff96d63-e80a-5855-80a2-b1b0885c5ab7"
9490
Mooncake = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
9591
MonteCarloMeasurements = "0987c9cc-fe09-11e8-30f0-b96dd679fdca"
96-
NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56"
9792
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
9893
Polyester = "f517fe37-dbe3-4b94-8317-1923a5111588"
9994
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
@@ -109,4 +104,4 @@ Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
109104
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
110105

111106
[targets]
112-
test = ["FastBroadcast", "ForwardDiff", "KernelAbstractions", "Measurements", "Mooncake", "NLsolve", "Pkg", "Polyester", "Random", "RecursiveArrayToolsShorthandConstructors", "ReverseDiff", "SafeTestsets", "SparseArrays", "StaticArrays", "Statistics", "StructArrays", "Tables", "Test", "Unitful", "Zygote"]
107+
test = ["FastBroadcast", "ForwardDiff", "KernelAbstractions", "Measurements", "Mooncake", "Pkg", "Polyester", "Random", "RecursiveArrayToolsShorthandConstructors", "ReverseDiff", "SafeTestsets", "SparseArrays", "StaticArrays", "Statistics", "StructArrays", "Tables", "Test", "Unitful", "Zygote"]

0 commit comments

Comments
 (0)