Implement Base.resize! for ArrayPartitions#487
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Oct 17, 2025
Merged
Conversation
3c597f7 to
e3e3bd7
Compare
Contributor
Author
|
@ChrisRackauckas can you please take a look at this? |
Member
|
This looks right, but can you measure the invalidations? |
Contributor
Performance Analysis ResultsAutomated analysis of PR #487 for potential invalidations and loading time impact. ✓ No Invalidations DetectedThe new method
Method analysis:
✓ No Loading Time IssuesBenchmark Results (Package Loading Time):
Key findings:
Why no impact? function Base.resize!(A::ArrayPartition, sizes::Tuple)
resize!.(A.x, sizes)
A
end
Conclusion✓ Safe to merge from a performance perspective No invalidations and no meaningful loading time impact detected. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SciML/OrdinaryDiffEq.jl#2890.