Add recursivefill! and recursivecopy! for ragged arrays#582
Add recursivefill! and recursivecopy! for ragged arrays#582ChrisRackauckas merged 6 commits intoSciML:masterfrom
recursivefill! and recursivecopy! for ragged arrays#582Conversation
|
I'm testing this PR in JoshuaLampert/SimpleDiscontinuousGalerkin.jl#74, where CI is still failing. I'm investigating. |
|
With this PR, the tests in https://github.com/JoshuaLampert/SimpleDiscontinuousGalerkin.jl/actions/runs/24992576972/job/73220281516 and the ragged array tests here are now passing. In addition to |
There was a problem hiding this comment.
This is circular: these overloads need to go into DiffEqBase instead.
There was a problem hiding this comment.
Totally fine with me. Do you (or one of your bots) create a PR in DiffEqBase.jl? Please ping me there if there is one.
There was a problem hiding this comment.
yeah sorry Mr. Bot is a bit slow right now with all the travel and the big stuff of the recent majors.
There was a problem hiding this comment.
Yeah, no worries. I removed the extension again as this will be handled in DiffEqBase.jl now. So I think this is ready from my side.
The functions
recursivefill!andrecursivecopy!were missing for the RecursiveArrayToolsRaggedArrays.jl sublibrary. Previously, the following MWE did not work:This PR fixes it.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.