Remove any/all overloads for ArrayPartition to eliminate invalidations#549
Closed
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Closed
Conversation
The custom `any(f::Function, A::ArrayPartition)` and `all(f::Function, A::ArrayPartition)` methods were the single largest source of invalidations when loading SciMLBase (575 children for `any` alone, caused by ambiguity with `Base.any(f::Function, a::AbstractArray)`). Since ArrayPartition is an AbstractVector with correct iteration, the default Base implementations produce identical results. The custom versions just short-circuited by partition component rather than element-by-element, which is a minor optimization not worth 575 invalidations. All RecursiveArrayTools tests pass with this change. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing — this is subsumed by #547 which removes all these overrides as part of the AbstractArray breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base.any(f, A::ArrayPartition),Base.any(f::Function, A::ArrayPartition),Base.all(f, A::ArrayPartition),Base.all(f::Function, A::ArrayPartition)overloadsBase.any(A::ArrayPartition)andBase.all(A::ArrayPartition)(these are removed too since the default works)Context
The
any(f::Function, A::ArrayPartition)specialization was the single largest source of method table invalidations when loading SciMLBase — 575 invalidated children — because it directly competes withBase.any(f::Function, a::AbstractArray; dims).Since
ArrayPartition <: AbstractVectorwith correct element iteration, the default Base implementations produce identical results. The custom versions iterated by partition component (A.x) rather than element-by-element, which is a minor optimization not worth 575 invalidations.Test plan
any/allwith lambda predicates produce correct results on ArrayPartition🤖 Generated with Claude Code