Fix FastBroadcast extension for v1.0 API#552
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Mar 31, 2026
Merged
Conversation
ChrisRackauckas-Claude
force-pushed
the
fix-fastbroadcast-v1
branch
2 times, most recently
from
be455ae to
5c5a22d
Compare
Update RecursiveArrayToolsFastBroadcastExt to use FastBroadcast v1.0's 2-arg fast_materialize!(dst, bc) signature instead of the old 4-arg fast_materialize!(::Static.False, ::DB, dst, bc). The 2-arg method is the base dispatch point that Serial() delegates to, so this covers all non-threaded paths. Require FastBroadcast >= 1.1. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
fix-fastbroadcast-v1
branch
from
5c5a22d to
6437f2c
Compare
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecursiveArrayToolsFastBroadcastExtto use FastBroadcast v1.0's 2-argfast_materialize!(dst, bc)signature instead of the old 4-argfast_materialize!(::Static.False, ::DB, dst, bc)"0.3.5, 1"to"1"since the extension code is incompatible with 0.3.xProblem
FastBroadcast v1.0 removed the
Staticmodule re-export and changed thefast_materialize!API. The current extension referencesFastBroadcast.Static.Falsewhich doesn't exist in v1.0+, causing a precompilation error:Despite the compat claiming
"0.3.5, 1", the extension was broken on v1.0.🤖 Generated with Claude Code