Add QA (Aqua/JET) groups to sublibraries (SciML/.github#77)#614
Merged
Conversation
Adds a canonical QA test group to each sublibrary:
RecursiveArrayToolsArrayPartitionAnyAll, RecursiveArrayToolsRaggedArrays,
RecursiveArrayToolsShorthandConstructors.
Each unit gets test/qa/{Project.toml,qa.jl} running Aqua.test_all +
JET.test_package(target_defined_modules=true), a QA dispatch in
test/runtests.jl gated on RECURSIVEARRAYTOOLS_TEST_GROUP == "QA" (with
the Julia < 1.11 [sources] develop fallback mirroring the root QA env),
Pkg wired into [extras]/[targets] with compat so Aqua deps_compat stays
green, and a [QA] entry (versions = ["lts", "1"]) in test_groups.toml.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
that referenced
this pull request
Jun 15, 2026
The ArrayPartitionAnyAll and ShorthandConstructors sublibrary QA groups (added in #614) fail Aqua's piracy check because they extend Base functions on RecursiveArrayTools-owned types: * ArrayPartitionAnyAll: any/all on ArrayPartition * ShorthandConstructors: getindex(::Type{VA}, ...), getindex(::Type{AP}, ...) These are intentional methods on types the sublibraries hard-depend on, not type piracy. Pass them via Aqua.test_all(...; piracies = (; treat_as_own = ...)) so the owned-type extensions are not flagged. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of SciML/.github#77 — canonical QA (Aqua + JET) groups for monorepo sublibraries.
Units in this batch
lib/RecursiveArrayToolsArrayPartitionAnyAlllib/RecursiveArrayToolsRaggedArrayslib/RecursiveArrayToolsShorthandConstructorsWhat each unit gets
test/qa/Project.toml: isolated QA env with Aqua + JET + Test and the sublibrary via[sources]path (compat: julia 1.10, Aqua 0.8, JET 0.9/0.10/0.11, Test 1).test/qa/qa.jl:Aqua.test_all+JET.test_package(...; target_defined_modules = true).test/runtests.jlgated onRECURSIVEARRAYTOOLS_TEST_GROUP == "QA", activating the qa env with the same Julia < 1.11[sources]-develop fallback the root QA env uses (develops both the sublibrary and the umbrella root so LTS tests PR-branch code).Pkgadded to[extras]/[targets]with a[compat]entry; missing compat entries for existing extras (Test,SparseArrays) added soAqua.test_deps_compatstays green.[QA]group intest/test_groups.tomlwithversions = ["lts", "1"](nopre, ubuntu-only), picked up by the centralizedsublibrary-project-tests.ymlmatrix.Verification was static only (TOML parse,
Meta.parseallon runtests/qa.jl,[sources]path resolution, extras-compat coverage); QA findings will be triaged from CI per the established mark-broken+issue policy.Further batches may be pushed to this branch. Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code