Skip to content

Fix sublibrary QA Aqua piracy via treat_as_own for owned types #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jun 15, 2026
Merged

Fix sublibrary QA Aqua piracy via treat_as_own for owned types #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/RecursiveArrayToolsArrayPartitionAnyAll/test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
using RecursiveArrayToolsArrayPartitionAnyAll, Aqua, JET, Test

const RATAPAA = RecursiveArrayToolsArrayPartitionAnyAll

@testset "QA" begin
@testset "Aqua" begin
Aqua.test_all(RecursiveArrayToolsArrayPartitionAnyAll)
# `any`/`all` are extended on the RecursiveArrayTools-owned `ArrayPartition`
# type, so they are intentional (owned) methods, not piracy.
Aqua.test_all(RATAPAA; piracies = (; treat_as_own = [RATAPAA.ArrayPartition]))
end
@testset "JET" begin
JET.test_package(RecursiveArrayToolsArrayPartitionAnyAll; target_defined_modules = true)
Expand Down
7 changes: 6 additions & 1 deletion lib/RecursiveArrayToolsShorthandConstructors/test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
using RecursiveArrayToolsShorthandConstructors, Aqua, JET, Test

const RATSC = RecursiveArrayToolsShorthandConstructors

@testset "QA" begin
@testset "Aqua" begin
Aqua.test_all(RecursiveArrayToolsShorthandConstructors)
# `getindex(::Type{VA}, ...)` / `getindex(::Type{AP}, ...)` extend Base on
# RecursiveArrayTools-owned types, so they are intentional (owned) methods,
# not piracy.
Aqua.test_all(RATSC; piracies = (; treat_as_own = [RATSC.VA, RATSC.AP]))
end
@testset "JET" begin
JET.test_package(RecursiveArrayToolsShorthandConstructors; target_defined_modules = true)
Expand Down
Loading