Avoid splatting in closures_to_opaque for faster Expr construction#116
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Apr 8, 2026
Conversation
Replace `Expr(head, array...)` with direct `.args` assignment to avoid the overhead of splatting. This is the hot path in recursive AST traversal and reduces RGF creation time by ~19% and allocations by ~10%. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expr(head, array...)withExpr(head)+ direct.argsassignment inclosures_to_opaqueto avoid the overhead of splattingExprnode that isn't a function def, generator, opaque_closure, or typed return:generatorbranch (lines 362, 368)Benchmark results
10,000 RGF creations of a moderately complex expression:
The improvement compounds in downstream packages (e.g. ModelingToolkit) that create many RGFs during precompilation/build.
Test plan
Pkg.test()passes — all tests pass including Aqua🤖 Generated with Claude Code