Skip to content

Avoid splatting in closures_to_opaque for faster Expr construction #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Apr 8, 2026
Merged

Avoid splatting in closures_to_opaque for faster Expr construction #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/RuntimeGeneratedFunctions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,14 +359,13 @@ function closures_to_opaque(ex::Expr, return_type = nothing)
end
return _ex
elseif head === :generator
f_args = Expr(:tuple, Any[x.args[1] for x in args[2:end]]...)
f_args = Expr(:tuple)
f_args.args = Any[x.args[1] for x in args[2:end]]
iters = Any[x.args[2] for x in args[2:end]]
return Expr(
:call,
GlobalRef(Base, :Generator),
closures_to_opaque(Expr(:(->), f_args, args[1])),
iters...
)
new_ex = Expr(:call, GlobalRef(Base, :Generator),
closures_to_opaque(Expr(:(->), f_args, args[1])))
append!(new_ex.args, iters)
return new_ex
elseif head === :opaque_closure
return closures_to_opaque(args[1])
elseif head === :return && return_type !== nothing
Expand All @@ -375,7 +374,9 @@ function closures_to_opaque(ex::Expr, return_type = nothing)
_tconvert(return_type, closures_to_opaque(args[1], return_type))
)
end
return Expr(head, Any[closures_to_opaque(x, return_type) for x in args]...)
new_ex = Expr(head)
new_ex.args = Any[closures_to_opaque(x, return_type) for x in args]
return new_ex
end

"""
Expand Down
Loading