fix isinplace inference and add inference tests#1019
Open
oscardssmith wants to merge 4 commits into
Open
Conversation
Closed
| hasmethod(f, ntuple(_->Any, outofplace_param_number)) && return false | ||
| hasmethod(f, ntuple(_->Any, inplace_param_number)) && return true | ||
| end | ||
| throw(FunctionArgumentsError(fname, f)) |
Member
There was a problem hiding this comment.
This error message loses a lot of information. Can we in the error path do a method check and throw the more informative error message?
Member
Author
There was a problem hiding this comment.
IMO the better method is to just put the expected nargs in the exception and then we can make the exception printing in charge of that logic. That way none of the complicated bits are in the main function.
Member
Author
|
I just remembered the tricky part here. This query isn't quite right (see JuliaLang/julia#56279 for details): |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1017
This also removes
NoMethodsError,TooManyArgumentsError, andTooFewArgumentsErrorand fixes inference for some*Functionconstructors`