Revert AutoSpecialize default for SciMLFunction constructors#1299
Merged
ChrisRackauckas merged 1 commit intoMar 30, 2026
Merged
Conversation
Only reverts ODEFunction, SplitFunction, and DynamicalODEFunction back to FullSpecialize. Other function types (NonlinearFunction, SDEFunction, DiscreteFunction, etc.) keep DEFAULT_SPECIALIZATION from SciML#1298. The ODEFunction change exposed multiple issues in OrdinaryDiffEq.jl: - BigFloat tableau c promotes t past FunctionWrapper signatures - GradientTracer types not in wrapper signatures (AutoSparse) - MatrixOperator jac_prototype causes promote_op → Union{} - Hard DAE numerical accuracy regression Deferring ODEFunction AutoSpecialize default to v4. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2715c0c to
a5c2176
Compare
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/SciMLBase.jl
that referenced
this pull request
Mar 30, 2026
Change ODEFunction, SplitFunction, and DynamicalODEFunction convenience constructors to use DEFAULT_SPECIALIZATION (AutoSpecialize) instead of FullSpecialize. This was reverted from v2 (SciML#1299) due to downstream issues that need to be fixed in OrdinaryDiffEq.jl v7. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 30, 2026
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 2, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 7, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 9, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
termi-official
pushed a commit
to termi-official/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 10, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 10, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 11, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 11, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 11, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 12, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 12, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 12, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 12, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 12, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 15, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 15, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 15, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 15, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 16, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 16, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 16, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 20, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Apr 21, 2026
OrdinaryDiffEq v7 needs FunctionWrappersWrappers v1 for proper fallback support with GradientTracer and other type-wrapping edge cases (see SciML/SciMLBase.jl#1299 and SciML/SciMLBase.jl#1300). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ODEFunction,SplitFunction, andDynamicalODEFunctionconvenience constructors back toFullSpecialize(from Use DEFAULT_SPECIALIZATION for all SciMLFunction constructors #1298)NonlinearFunction,SDEFunction,DiscreteFunction,DAEFunction,RODEFunction, etc.) keepDEFAULT_SPECIALIZATIONas intendedThe ODEFunction change exposed multiple breaking issues in OrdinaryDiffEq.jl CI:
cpromotestpastFunctionWrappersignatures — requires tableau constructors to take separate state/time typesGradientTracertype not in wrapper signatures — AutoSparse sparsity detection passes tracer types through the wrapped functionMatrixOperatorjac_prototype causespromote_op→Union{}—promote_fcan't handle operator-based JacobiansDeferring ODEFunction AutoSpecialize default to v4 where these can be addressed properly.
Test plan