AutoSpecialize for NonlinearProblem#862
Open
oscardssmith wants to merge 1 commit intoSciML:masterfrom
Open
Conversation
Member
Author
|
interestingly, even with this, NonlinearSolve is still 99% compilation time... |
Member
|
@avik-pal test it a bit? |
Member
Do you mean the current precompile workload? I think it manually sets the specialization so it has no effect. Also we would need the corresponding DiffEqBase update for this to work I think |
Member
Author
|
I changed the workload to make |
Member
Member
Author
|
That very specifically shouldn't be needed. The key observation of this PR is that you don't actually need to FunctionWrap in place functions since you can just do a dynamic dispatch instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since
NonlinearProblemdoesn't have atfield, most of the time, we can just useVoidfor all of the functions of inplace ones without a performance penalty. This still needs to be benchmarked to make sure it doesn't have a performance impact.