Change the scale of the figures in the spatial benchmark.#742
Draft
Vilin97 wants to merge 3 commits intoSciML:masterfrom
Draft
Change the scale of the figures in the spatial benchmark.#742Vilin97 wants to merge 3 commits intoSciML:masterfrom
Vilin97 wants to merge 3 commits intoSciML:masterfrom
Conversation
Contributor
Author
|
@isaacsas , I can't tell if the file ran correctly. How can I see the produced document? |
Member
|
Open the CI and click to artifacts.
|
Contributor
Author
|
The figures are supposed to include benchmarks though. |
Member
|
yes, the markdown says it errored plt=fetch_and_plot(bench_dict, domain_len) |
Member
|
@isaacsas is it worth reviving this? |
Member
|
Yes, definitely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Sanft's paper they report the number of channels on the x axis. So I changed this benchmark to do the same. I also reduced the number of sites we benchmark on so that it matches the numbers from the paper.