Skip to content

Commit 629738e

Browse files
committed
removing unnecessary simplification for id assessment
1 parent 6152dd1 commit 629738e

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

src/known_ic.jl

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,17 @@ function _find_identifiable_functions_kic(
4747
seed = seed,
4848
)
4949

50-
rff = RationalFunctionField(
51-
vcat(id_funcs_general, [f // one(parent(ode)) for f in known_ic]),
52-
)
53-
@debug generators(rff)
50+
id_funcs = vcat(id_funcs_general, [f // one(parent(ode)) for f in known_ic])
5451

55-
id_funcs = simplified_generating_set(
56-
rff,
57-
prob_threshold = half_p,
58-
seed = seed,
59-
simplify = simplify,
60-
rational_interpolator = rational_interpolator,
61-
)
52+
if (simplify != :absent)
53+
id_funcs = simplified_generating_set(
54+
RationalFunctionField(id_funcs),
55+
prob_threshold = half_p,
56+
seed = seed,
57+
simplify = simplify,
58+
rational_interpolator = rational_interpolator,
59+
)
60+
end
6261

6362
@info "The search for identifiable functions with known initial conditions concluded in $((time_ns() - runtime_start) / 1.0e9) seconds"
6463

@@ -92,7 +91,7 @@ function _assess_identifiability_kic(
9291
funcs_to_check = vcat(ode.x_vars, ode.parameters)
9392
end
9493
half_p = 0.5 + prob_threshold / 2
95-
id_funcs = _find_identifiable_functions_kic(ode, known_ic, prob_threshold = half_p)
94+
id_funcs = _find_identifiable_functions_kic(ode, known_ic, prob_threshold = half_p, simplify = :absent)
9695
#funcs_to_check = replace_with_ic(ode, funcs_to_check)
9796
result = OrderedDict(f => :globally for f in funcs_to_check)
9897

0 commit comments

Comments
 (0)