QA: run_qa v1.6 form + ExplicitImports (#165)

* QA: run_qa v1.6 form + ExplicitImports

Convert test/qa/qa.jl from the hand-rolled SafeTestsets + Aqua.test_all +
JET.test_package layout to SciMLTesting 1.6's run_qa, and turn on the
ExplicitImports checks (explicit_imports = true).

- Aqua: piracies stays disabled and tracked via aqua_broken = (:piracies,)
  (was Aqua.test_all(...; piracies = false) + @test_broken false), issue #156.
- JET: still runs (jet_kwargs = (; target_defined_modules = true)).
- ExplicitImports (6 checks):
  - no_stale_explicit_imports: drop unused `coeff` from the Symbolics import.
  - all_qualified_accesses_via_owners / *_are_public / all_explicit_imports_are_public:
    ignore upstream non-public / re-exported names (Symbolics, SymbolicUtils,
    DataDrivenDiffEq, DataDrivenSparse) via per-check ei_kwargs ignore-lists.
  - no_implicit_imports: many heavy-`using` names across the Symbolics/DataDriven
    stacks; marked ei_broken = (:no_implicit_imports,) and tracked in issue #164
    rather than a risky mass explicit-import refactor.

qa env: add SciMLTesting (compat "1.6"), drop SafeTestsets (run_qa owns the
testset); ExplicitImports comes in transitively via SciMLTesting; Aqua stays a
direct dep (its ambiguities sub-check spawns a child process).

Verified locally against released SciMLTesting 1.6.0 (Aqua 0.8.16, JET 0.9.18,
ExplicitImports 1.15.0): Quality Assurance | 16 Pass, 2 Broken, 0 Fail/Error.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* QA: trim redundant public-API EI ignores after SciMLTesting 1.7 + base-lib make-public

SciMLTesting 1.7 runs check_all_qualified_accesses_are_public and
check_all_explicit_imports_are_public only on Julia >= 1.11. With the
released Symbolics 7.29.0 / SymbolicUtils 4.36.0 now declaring several
formerly-internal names public, the per-repo public-API ignore lists are
largely redundant.

Emptied both public-API ignore lists and re-verified on Julia 1.12
(>= 1.11, where the checks run) against the registered releases, then
restored only the names still flagged as non-public:

  all_qualified_accesses_are_public: AbstractDataDrivenAlgorithm
  (DataDrivenDiffEq), Sym (SymbolicUtils), active_set!/coef
  (DataDrivenSparse), toexpr (Symbolics)
  all_explicit_imports_are_public: issym (SymbolicUtils)

Removed (now public): derivative, scalarize, unwrap, value
(all_qualified_accesses_are_public); BasicSymbolic, get_variables, value
(all_explicit_imports_are_public).

The all_qualified_accesses_via_owners ignore, aqua_broken, and ei_broken
are left untouched. Verified: Julia 1.12 QA group green for both public
checks; Julia 1.10 (lts) skips them per SciMLTesting 1.7.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* QA: require SciMLTesting >= 1.7 for gated public-API EI checks

The public-API ExplicitImports checks (all_qualified_accesses_are_public /
all_explicit_imports_are_public) are gated to Julia >= 1.11 starting in
SciMLTesting 1.7. Bump the qa env compat floor so CI resolves the gating
release rather than an older SciMLTesting that would skip those checks.

Verified against the registered make-public releases (SciMLBase 3.27.0,
SciMLTesting 1.7.0, Symbolics 7.29.0, SymbolicUtils 4.36.0):
- Julia 1.12 (public-API checks run): 16 pass, 2 broken, 0 fail. The
  emptied public-API ignore lists flag exactly 6 survivors, all from
  packages outside the make-public scope and kept ALLOWED:
  AbstractDataDrivenAlgorithm (DataDrivenDiffEq); Sym, issym (SymbolicUtils);
  active_set!, coef (DataDrivenSparse); toexpr (Symbolics).
- Julia 1.10 (public-API checks skipped via the 1.7 gate): 14 pass,
  2 broken, 0 fail.

This package has no SciMLBase/DiffEqBase dependency, so no caller migration
applies; the restored ignore lists are unchanged from the prior commit.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* QA: trim now-public ExplicitImports ignores

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

* QA: thorough EI ignore re-clean (drop stale incl via_owners, migrate non-public re-exports)

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

---------

Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: 3 people

src/SymbolicNumericIntegration.jl

@@ -5,7 +5,7 @@ using TermInterface: iscall
 using SymbolicUtils
 using SymbolicUtils: operation, arguments
 using Symbolics
-using Symbolics: value, get_variables, expand_derivatives, coeff, Equation
+using Symbolics: value, get_variables, expand_derivatives, Equation
 using SymbolicUtils.Rewriters
 using SymbolicUtils: issym, BasicSymbolic
 

test/qa/Project.toml

@@ -1,7 +1,7 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
-SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 SymbolicNumericIntegration = "78aadeae-fbc0-11eb-17b6-c7ec0477ba9e"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
@@ -11,5 +11,6 @@ SymbolicNumericIntegration = {path = "../.."}
 [compat]
 Aqua = "0.8"
 JET = "0.9,0.10,0.11"
+SciMLTesting = "1.7"
 Test = "1"
 julia = "1.10"

test/qa/qa.jl

@@ -1,18 +1,34 @@
-using SafeTestsets
+using SymbolicNumericIntegration, Test
+using JET
+using SciMLTesting
 
-@safetestset "Aqua" begin
-    using SymbolicNumericIntegration
-    using Aqua
-    using Test
-
-    Aqua.test_all(SymbolicNumericIntegration; piracies = false)
-    @test_broken false  # Aqua piracy: Base.signbit(::Complex)/signbit(::SymbolicUtils.Sym) in src/integral.jl + DataDrivenSparse.active_set! in src/sparse.jl — see https://github.com/SciML/SymbolicNumericIntegration.jl/issues/156
-end
-
-@safetestset "JET" begin
-    using SymbolicNumericIntegration
-    using JET
-    using Test
-
-    JET.test_package(SymbolicNumericIntegration; target_defined_modules = true)
-end
+run_qa(
+    SymbolicNumericIntegration;
+    explicit_imports = true,
+    jet_kwargs = (; target_defined_modules = true),
+    # Aqua piracy: Base.signbit(::Complex)/signbit(::SymbolicUtils.Sym) in
+    # src/integral.jl + DataDrivenSparse.active_set! in src/sparse.jl
+    # https://github.com/SciML/SymbolicNumericIntegration.jl/issues/156
+    aqua_broken = (:piracies,),
+    ei_kwargs = (;
+        # Re-exports: accessed from the re-exporting module rather than the owner.
+        # coef -> StatsAPI (via DataDrivenSparse); toexpr -> SymbolicUtils.Code
+        # (via Symbolics). Neither owner is a SciML make-public target.
+        all_qualified_accesses_via_owners = (;
+            ignore = (:coef, :toexpr),
+        ),
+        # Non-public names of upstream packages accessed via qualification.
+        # AbstractDataDrivenAlgorithm: DataDrivenDiffEq; active_set!, coef:
+        # DataDrivenSparse; toexpr: Symbolics.
+        all_qualified_accesses_are_public = (;
+            ignore = (
+                :AbstractDataDrivenAlgorithm, :active_set!, :coef, :toexpr,
+            ),
+        ),
+    ),
+    # Heavy `using` of the Symbolics/SymbolicUtils/DataDriven stacks (macros +
+    # module bindings used for qualified access) — tracked for a follow-up
+    # explicit-import pass rather than a risky mass refactor.
+    # https://github.com/SciML/SymbolicNumericIntegration.jl/issues/164
+    ei_broken = (:no_implicit_imports,),
+)