Fix QA test group routing (GROUP="QA" had no qa body)#161
Merged
ChrisRackauckas merged 1 commit intoJun 20, 2026
Merged
Conversation
GROUP="QA" CI was failing with:
ArgumentError: run_tests: GROUP="QA" was requested but no `qa` body
was provided
`test/runtests.jl` declared the QA group as a `"QA"` key inside the
`groups` Dict. But `"QA"` is a reserved group name in SciMLTesting:
when GROUP="QA" is requested, `run_tests` dispatches to its dedicated
`qa` keyword argument, not to a `groups["QA"]` entry. With `qa` left
unset, the reserved-name branch threw before the `groups` table was
ever consulted, so the Aqua/JET bodies never ran and the QA job errored
on both the `1` and `lts` channels. Core was unaffected because `core`
was passed correctly.
Move the QA spec out of `groups` and into the `qa` keyword, matching the
canonical single-package form documented in SciMLTesting.
Verified against released SciMLTesting v1 on Julia 1.12: the old
`groups = Dict("QA" => ...)` form reproduces the exact CI ArgumentError,
while the `qa = (; env, body)` form routes GROUP="QA" to the QA body, and
GROUP="Core" still runs only core.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tests / QAjobs onmain(both Julia1andlts) fail at startup with:Root cause
test/runtests.jldeclared the QA group as a"QA"key inside thegroupsDict passed toSciMLTesting.run_tests. But"QA"is a reserved group name in SciMLTesting (alongsideAll/Core). WhenGROUP="QA"is requested,run_testsdispatches to its dedicatedqakeyword argument — it never consultsgroups["QA"]. Withqaleft unset, the reserved-name branch throws theArgumentErrorabove before thegroupstable is reached, so the Aqua/JET bodies never run.Core was green because
corewas passed correctly; only QA was misrouted.Fix
Move the QA spec out of
groupsand into the dedicatedqakeyword, matching the canonical single-package form in the SciMLTesting docstring:No change to
test/qa/qa.jl(Aqua + JET) ortest/test_groups.toml.Local verification
Against released SciMLTesting v1 on Julia 1.12 (the
1CI channel):groups = Dict("QA" => ...)form → reproduces the exact CIArgumentError.qa = (; env, body)form →GROUP="QA"routes to and runs the QA body.GROUP="Core"still runs onlycore, QA does not run (no regression to the passing Core group).Please ignore until reviewed by @ChrisRackauckas