Skip to content

Commit 093c681

Browse files
committed
optimize CronTabHook
1 parent 0302ccc commit 093c681

3 files changed

Lines changed: 10 additions & 22 deletions

File tree

src/Infrastructure/BotSharp.Core.Crontab/Abstraction/ICrontabAuthenticationHook.cs

Lines changed: 0 additions & 13 deletions
This file was deleted.
Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,20 @@
11
namespace BotSharp.Core.Crontab.Abstraction;
22

3-
public interface ICrontabHook
3+
public abstract class ICrontabHook
44
{
5-
string[]? Triggers
5+
public string[]? Triggers
66
=> null;
77

8-
Task OnCronTriggered(CrontabItem item)
8+
public virtual void OnAuthenticate(CrontabItem item)
9+
{
10+
}
11+
12+
public Task OnCronTriggered(CrontabItem item)
913
=> Task.CompletedTask;
1014

11-
Task OnTaskExecuting(CrontabItem item)
15+
public Task OnTaskExecuting(CrontabItem item)
1216
=> Task.CompletedTask;
1317

14-
Task OnTaskExecuted(CrontabItem item)
18+
public Task OnTaskExecuted(CrontabItem item)
1519
=> Task.CompletedTask;
1620
}

src/Infrastructure/BotSharp.Core.Crontab/Services/CrontabService.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,15 +115,12 @@ private string FormatCrontabName(string trigger, string agent)
115115
public async Task ScheduledTimeArrived(CrontabItem item)
116116
{
117117
_logger.LogDebug($"ScheduledTimeArrived {item}");
118-
HookEmitter.Emit<ICrontabAuthenticationHook>(_services, hook =>
119-
{
120-
hook.SetUserIdentity(item);
121-
});
122118

123119
await HookEmitter.Emit<ICrontabHook>(_services, async hook =>
124120
{
125121
if (hook.Triggers == null || hook.Triggers.Contains(item.Title))
126122
{
123+
hook.OnAuthenticate(item);
127124
await hook.OnTaskExecuting(item);
128125
await hook.OnCronTriggered(item);
129126
await hook.OnTaskExecuted(item);

0 commit comments

Comments
 (0)