refine global stats

Author: iceljc

src/Infrastructure/BotSharp.Abstraction/Repositories/IBotSharpRepository.cs

@@ -187,9 +187,9 @@ List<string> GetInstructionLogSearchKeys(InstructLogKeysFilter filter)
     #endregion
 
     #region Statistics
-    BotSharpStats? GetGlobalStats(string metric, string dimension, string dimRefVal, DateTime recordTime, StatsInterval interval)
+    BotSharpStats? GetGlobalStats(string agentId, DateTime recordTime, StatsInterval interval)
         => throw new NotImplementedException();
-    bool SaveGlobalStats(BotSharpStats body)
+    bool SaveGlobalStats(BotSharpStatsDelta delta)
         => throw new NotImplementedException();
 
     #endregion

src/Infrastructure/BotSharp.Abstraction/Statistics/Models/BotSharpStats.cs

@@ -4,17 +4,23 @@ namespace BotSharp.Abstraction.Statistics.Models;
 
 public class BotSharpStats
 {
-    [JsonPropertyName("metric")]
-    public string Metric { get; set; } = null!;
+    [JsonPropertyName("agent_id")]
+    public string AgentId { get; set; } = null!;
 
-    [JsonPropertyName("dimension")]
-    public string Dimension { get; set; } = null!;
+    [JsonPropertyName("agent_call_count")]
+    public int AgentCallCount { get; set; }
 
-    [JsonPropertyName("dim_ref_val")]
-    public string DimRefVal { get; set; } = null!;
+    [JsonPropertyName("prompt_tokens")]
+    public int PromptTokens { get; set; }
 
-    [JsonPropertyName("data")]
-    public IDictionary<string, double> Data { get; set; } = new Dictionary<string, double>();
+    [JsonPropertyName("completion_tokens")]
+    public int CompletionTokens { get; set; }
+
+    [JsonPropertyName("prompt_total_cost")]
+    public float PromptTotalCost { get; set; }
+
+    [JsonPropertyName("completion_total_cost")]
+    public float CompletionTotalCost { get; set; }
 
     [JsonPropertyName("record_time")]
     public DateTime RecordTime { get; set; } = DateTime.UtcNow;
@@ -44,11 +50,13 @@ public string Interval
     [JsonPropertyName("end_time")]
     public DateTime EndTime { get; set; }
 
+
     public override string ToString()
     {
-        return $"{Metric}-{Dimension}-{DimRefVal} ({Interval}): {Data?.Count ?? 0}";
+        return $"Stats: {AgentId}-{IntervalType}";
     }
 
+
     public static (DateTime, DateTime) BuildTimeInterval(DateTime recordTime, StatsInterval interval)
     {
         DateTime startTime = recordTime;

src/Infrastructure/BotSharp.Abstraction/Statistics/Models/BotSharpStatsDelta.cs

@@ -0,0 +1,30 @@
+using BotSharp.Abstraction.Statistics.Enums;
+
+namespace BotSharp.Abstraction.Statistics.Models;
+
+public class BotSharpStatsDelta
+{
+    public string AgentId { get; set; } = null!;
+    public int AgentCallCountDelta { get; set; }
+    public int PromptTokensDelta { get; set; }
+    public int CompletionTokensDelta { get; set; }
+    public float PromptTotalCostDelta { get; set; }
+    public float CompletionTotalCostDelta { get; set; }
+    public DateTime RecordTime { get; set; } = DateTime.UtcNow;
+    public StatsInterval IntervalType { get; set; } = StatsInterval.Day;
+
+    public string Interval
+    {
+        get
+        {
+            return IntervalType.ToString();
+        }
+        set
+        {
+            if (Enum.TryParse(value, out StatsInterval type))
+            {
+                IntervalType = type;
+            }
+        }
+    }
+}

src/Infrastructure/BotSharp.Abstraction/Statistics/Models/BotSharpStatsInput.cs

@@ -4,5 +4,5 @@ namespace BotSharp.Abstraction.Statistics.Services;
 
 public interface IBotSharpStatsService
 {
-    bool UpdateStats(string resourceKey, BotSharpStatsInput input);
+    bool UpdateStats(string @event, BotSharpStatsDelta delta);
 }

src/Infrastructure/BotSharp.Abstraction/Statistics/Models/StatsKeyValuePair.cs

@@ -73,21 +73,17 @@ public void AddToken(TokenStatsModel stats, RoleDialogModel message)
         var dim = "agent";
         var agentId = message.CurrentAgentId ?? string.Empty;
         var globalStats = _services.GetRequiredService<IBotSharpStatsService>();
-        var body = new BotSharpStatsInput
+        var delta = new BotSharpStatsDelta
         {
-            Metric = metric,
-            Dimension = dim,
-            DimRefVal = agentId,
+            AgentId = agentId,
             RecordTime = DateTime.UtcNow,
             IntervalType = StatsInterval.Day,
-            Data = [
-                new StatsKeyValuePair("prompt_token_count_total", stats.TotalInputTokens),
-                new StatsKeyValuePair("completion_token_count_total", stats.TotalOutputTokens),
-                new StatsKeyValuePair("prompt_cost_total", deltaPromptCost),
-                new StatsKeyValuePair("completion_cost_total", deltaCompletionCost)
-            ]
+            PromptTokensDelta = stats.TotalInputTokens,
+            CompletionTokensDelta = stats.TotalOutputTokens,
+            PromptTotalCostDelta = deltaPromptCost,
+            CompletionTotalCostDelta = deltaCompletionCost
         };
-        globalStats.UpdateStats($"global-{metric}-{dim}-{agentId}", body);
+        globalStats.UpdateStats($"global-{metric}-{dim}-{agentId}", delta);
     }
 
     public void PrintStatistics()

src/Infrastructure/BotSharp.Abstraction/Statistics/Services/IBotSharpStatsService.cs

@@ -4,74 +4,100 @@ namespace BotSharp.Core.Repository;
 
 public partial class FileRepository
 {
-    public BotSharpStats? GetGlobalStats(string metric, string dimension, string dimRefVal, DateTime recordTime, StatsInterval interval)
+    public BotSharpStats? GetGlobalStats(string agentId, DateTime recordTime, StatsInterval interval)
     {
+        if (string.IsNullOrWhiteSpace(agentId))
+        {
+            return null;
+        }
+
         var baseDir = Path.Combine(_dbSettings.FileRepository, STATS_FOLDER);
         var (startTime, endTime) = BotSharpStats.BuildTimeInterval(recordTime, interval);
-        var dir = Path.Combine(baseDir, metric, startTime.Year.ToString(), startTime.Month.ToString("D2"));
-        if (!Directory.Exists(dir)) return null;
+        var dir = Path.Combine(baseDir, agentId, startTime.Year.ToString(), startTime.Month.ToString("D2"));
+        if (!Directory.Exists(dir))
+        {
+            return null;
+        }
 
         var file = Directory.GetFiles(dir).FirstOrDefault(x => Path.GetFileName(x) == STATS_FILE);
-        if (file == null) return null;
+        if (file == null)
+        {
+            return null;
+        }
 
         var text = File.ReadAllText(file);
         var list = JsonSerializer.Deserialize<List<BotSharpStats>>(text, _options);
-        var found = list?.FirstOrDefault(x => x.Metric.IsEqualTo(metric)
-                                            && x.Dimension.IsEqualTo(dimension)
-                                            && x.DimRefVal.IsEqualTo(dimRefVal)
+        var found = list?.FirstOrDefault(x => x.AgentId.IsEqualTo(agentId)
                                             && x.StartTime == startTime
                                             && x.EndTime == endTime);
 
         return found;
     }
 
-    public bool SaveGlobalStats(BotSharpStats body)
+    public bool SaveGlobalStats(BotSharpStatsDelta delta)
     {
+        if (delta == null || string.IsNullOrWhiteSpace(delta.AgentId))
+        {
+            return false;
+        }
+
         var baseDir = Path.Combine(_dbSettings.FileRepository, STATS_FOLDER);
-        var (startTime, endTime) = BotSharpStats.BuildTimeInterval(body.RecordTime, body.IntervalType);
-        body.StartTime = startTime;
-        body.EndTime = endTime;
+        var (startTime, endTime) = BotSharpStats.BuildTimeInterval(delta.RecordTime, delta.IntervalType);
 
-        var dir = Path.Combine(baseDir, body.Metric, startTime.Year.ToString(), startTime.Month.ToString("D2"));
+        var dir = Path.Combine(baseDir, delta.AgentId, startTime.Year.ToString(), startTime.Month.ToString("D2"));
         if (!Directory.Exists(dir))
         {
             Directory.CreateDirectory(dir);
         }
 
+        var newItem = new BotSharpStats
+        {
+            AgentId = delta.AgentId,
+            AgentCallCount = delta.AgentCallCountDelta,
+            PromptTokens = delta.PromptTokensDelta,
+            CompletionTokens = delta.CompletionTokensDelta,
+            PromptTotalCost = delta.PromptTotalCostDelta,
+            CompletionTotalCost = delta.CompletionTotalCostDelta,
+            RecordTime = delta.RecordTime,
+            StartTime = startTime,
+            EndTime = endTime,
+            Interval = delta.Interval
+        };
+
         var file = Path.Combine(dir, STATS_FILE);
         if (!File.Exists(file))
         {
-            var list = new List<BotSharpStats> { body };
+            var list = new List<BotSharpStats> { newItem };
             File.WriteAllText(file, JsonSerializer.Serialize(list, _options));
         }
         else
         {
             var text = File.ReadAllText(file);
             var list = JsonSerializer.Deserialize<List<BotSharpStats>>(text, _options);
-            var found = list?.FirstOrDefault(x => x.Metric.IsEqualTo(body.Metric)
-                                                && x.Dimension.IsEqualTo(body.Dimension)
-                                                && x.DimRefVal.IsEqualTo(body.DimRefVal)
+            var found = list?.FirstOrDefault(x => x.AgentId.IsEqualTo(delta.AgentId)
                                                 && x.StartTime == startTime
                                                 && x.EndTime == endTime);
 
             if (found != null)
             {
-                found.Metric = body.Metric;
-                found.Dimension = body.Dimension;
-                found.DimRefVal = body.DimRefVal;
-                found.Data = body.Data;
-                found.RecordTime = body.RecordTime;
-                found.StartTime = body.StartTime;
-                found.EndTime = body.EndTime;
-                found.Interval = body.Interval;
+                found.AgentId = delta.AgentId;
+                found.RecordTime = delta.RecordTime;
+                found.AgentCallCount += delta.AgentCallCountDelta;
+                found.PromptTokens += delta.PromptTokensDelta;
+                found.CompletionTokens += delta.CompletionTokensDelta;
+                found.PromptTotalCost += delta.PromptTotalCostDelta;
+                found.CompletionTotalCost += delta.CompletionTotalCostDelta;
+                found.StartTime = startTime;
+                found.EndTime = endTime;
+                found.Interval = delta.Interval;
             }
             else if (list != null)
             {
-                list.Add(body);
+                list.Add(newItem);
             }
             else if (list == null)
             {
-                list = new List<BotSharpStats> { body };
+                list = [newItem];
             }
 
             File.WriteAllText(file, JsonSerializer.Serialize(list, _options));

src/Infrastructure/BotSharp.Core/Conversations/Services/TokenStatistics.cs

@@ -9,8 +9,6 @@ public class BotSharpStatsService : IBotSharpStatsService
     private readonly ILogger<BotSharpStatsService> _logger;
     private readonly StatisticsSettings _settings;
 
-    private const int TIMEOUT_SECONDS = 5;
-
     public BotSharpStatsService(
         IServiceProvider services,
         ILogger<BotSharpStatsService> logger,
@@ -22,74 +20,24 @@ public BotSharpStatsService(
     }
 
 
-    public bool UpdateStats(string resourceKey, BotSharpStatsInput input)
+    public bool UpdateStats(string @event, BotSharpStatsDelta delta)
     {
         try
         {
             if (!_settings.Enabled
-                || string.IsNullOrEmpty(resourceKey)
-                || input == null
-                || string.IsNullOrEmpty(input.Metric)
-                || string.IsNullOrEmpty(input.Dimension)
-                || string.IsNullOrEmpty(input.DimRefVal)
-                || input.Data.IsNullOrEmpty())
+                || delta == null
+                || string.IsNullOrEmpty(delta.AgentId))
             {
                 return false;
             }
-          
-            var locker = _services.GetRequiredService<IDistributedLocker>();
-            var res = locker.Lock(resourceKey, () =>
-            {
-                var db = _services.GetRequiredService<IBotSharpRepository>();
-                var body = db.GetGlobalStats(input.Metric, input.Dimension, input.DimRefVal, input.RecordTime, input.IntervalType);
-                if (body == null)
-                {
-                    var stats = new BotSharpStats
-                    {
-                        Metric = input.Metric,
-                        Dimension = input.Dimension,
-                        DimRefVal = input.DimRefVal,
-                        RecordTime = input.RecordTime,
-                        IntervalType = input.IntervalType,
-                        Data = input.Data.ToDictionary(x => x.Key, x => x.Value)
-                    };
-                    db.SaveGlobalStats(stats);
-                    return;
-                }
-
-                foreach (var item in input.Data)
-                {
-                    var curValue = item.Value;
-                    if (body.Data.TryGetValue(item.Key, out var preValue))
-                    {
-                        switch (item.Operation)
-                        {
-                            case StatsOperation.Add:
-                                preValue += curValue;
-                                break;
-                            case StatsOperation.Subtract:
-                                preValue -= curValue;
-                                break;
-                            case StatsOperation.Reset:
-                                preValue = 0;
-                                break;
-                        }
-                        body.Data[item.Key] = preValue;
-                    }
-                    else
-                    {
-                        body.Data[item.Key] = curValue;
-                    }
-                }
-
-                db.SaveGlobalStats(body);
-            }, TIMEOUT_SECONDS);
 
-            return res;
+            var db = _services.GetRequiredService<IBotSharpRepository>();
+            var isSaved = db.SaveGlobalStats(delta);
+            return isSaved;
         }
         catch (Exception ex)
         {
-            _logger.LogError(ex, $"Error when updating global stats {input.Metric}-{input.Dimension}-{input.DimRefVal}.");
+            _logger.LogError(ex, $"Error when updating global stats {@event} (agent id: {delta?.AgentId}).");
             return false;
         }
     }