Clean code and refactor

Visagan Guruparan · Visagan Guruparan · commit f996c02ea05e · 2026-05-04T13:15:09.000-05:00
diff --git a/src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs b/src/Infrastructure/BotSharp.OpenAPI/Controllers/Agent/AgentController.Rule.cs
@@ -9,7 +9,10 @@ public partial class AgentController
     public IEnumerable<AgentRuleViewModel> GetRuleTriggers(string agentId)
     {
         var triggers = _services.GetServices<IRuleTrigger>();
-        triggers = triggers.Where(x => x.AgentIds == null || !x.AgentIds.Any() || x.AgentIds.Contains(agentId));
+        if (!string.IsNullOrWhiteSpace(agentId))
+        {
+            triggers = triggers.Where(x => x.AgentIds == null || x.AgentIds.Contains(agentId, StringComparer.OrdinalIgnoreCase));
+        }
         return triggers.Select(x => new AgentRuleViewModel
         {
             TriggerName = x.Name,

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,10 @@ public partial class AgentController`
`9`	`9`	`public IEnumerable<AgentRuleViewModel> GetRuleTriggers(string agentId)`
`10`	`10`	`{`
`11`	`11`	`var triggers = _services.GetServices<IRuleTrigger>();`
`12`		`- triggers = triggers.Where(x => x.AgentIds == null \|\| !x.AgentIds.Any() \|\| x.AgentIds.Contains(agentId));`
	`12`	`+ if (!string.IsNullOrWhiteSpace(agentId))`
	`13`	`+ {`
	`14`	`+ triggers = triggers.Where(x => x.AgentIds == null \|\| x.AgentIds.Contains(agentId, StringComparer.OrdinalIgnoreCase));`
	`15`	`+ }`
`13`	`16`	`return triggers.Select(x => new AgentRuleViewModel`
`14`	`17`	`{`
`15`	`18`	`TriggerName = x.Name,`