Upgrade all projects from netstandard2.0/netcoreapp2.x to net8.0;net10.0 multi-target

Nucs · Nucs · commit 715c42342f53 · 2026-02-08T09:25:29.000+02:00
All 7 projects now target net8.0 and net10.0, dropping netstandard2.0,
netcoreapp2.1, and netcoreapp2.2. LangVersion bumped from 12.0 to latest.

Target framework changes:
- NumSharp.Core: netstandard2.0 → net8.0;net10.0
- NumSharp.Bitmap: netstandard2.0 → net8.0;net10.0
- NumSharp.UnitTest: net8.0 → net8.0;net10.0
- NumSharp.Benchmark: net8.0 → net8.0;net10.0
- NeuralNetwork.NumSharp: netstandard2.0 → net8.0;net10.0
- NumSharp.Examples: netcoreapp2.2 → net8.0;net10.0
- NumSharp.ConsumePackage: netcoreapp2.1 → net8.0;net10.0

Removed redundant NuGet packages:
- System.Memory (4.5.5) — built into net8.0+ runtime
- System.Runtime.CompilerServices.Unsafe (6.0.0) — built into net8.0+ runtime
  Removed from: NumSharp.Core, NumSharp.UnitTest, NumSharp.Benchmark

Code fixes required by the upgrade:
- SteppingExtension.cs, SteppingOverArray.cs: disambiguate array.Reverse()
  calls to array.AsEnumerable().Reverse() — in net8.0+,
  MemoryExtensions.Reverse(Span&lt;T&gt;) takes precedence over LINQ's
  Enumerable.Reverse&lt;T&gt;() for arrays, returning void instead of IEnumerable
- ShallowWater.cs: fix stale 'using NumSharp.Core' → 'using NumSharp'

Carried forward from dev (uncommitted):
- UnmanagedStorage.Slicing.cs: broadcast slice fix — materialize broadcast
  data into contiguous memory with Clean() shape before slicing, preventing
  stride mismatch when broadcast strides [1,0] are applied to contiguous
  data layout [3,1]

Test results: identical on both TFMs (1601 passed, 50 failed, 36 skipped),
matching the dev branch baseline exactly. Zero regressions from the upgrade.
diff --git a/examples/NeuralNetwork.NumSharp/NeuralNetwork.NumSharp.csproj b/examples/NeuralNetwork.NumSharp/NeuralNetwork.NumSharp.csproj
@@ -1,12 +1,12 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
     <Platforms>AnyCPU;x64</Platforms>
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>Open.snk</AssemblyOriginatorKeyFile>
     <Configurations>Debug;Release</Configurations>
-    <LangVersion>12.0</LangVersion>
+    <LangVersion>latest</LangVersion>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/NumSharp.Bitmap/NumSharp.Bitmap.csproj b/src/NumSharp.Bitmap/NumSharp.Bitmap.csproj
@@ -1,6 +1,6 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <Authors>Eli Belash, Haiping Chen, Meinrad Recheis</Authors>
@@ -15,7 +15,7 @@
     <RepositoryType>git</RepositoryType>
     <PackageTags>Numpy, NumSharp, MachineLearning, Math, Scientific, Numeric, Mathlab, SciSharp</PackageTags>
     <PackageLicenseUrl></PackageLicenseUrl>
-    <LangVersion>12.0</LangVersion>
+    <LangVersion>latest</LangVersion>
     <PackageIconUrl>https://avatars3.githubusercontent.com/u/44989469?s=200&amp;v=4</PackageIconUrl>
     <PackageId>NumSharp.Bitmap</PackageId>
     <Product>NumSharp.Bitmap</Product>
diff --git a/src/NumSharp.Core/Backends/Unmanaged/UnmanagedStorage.Slicing.cs b/src/NumSharp.Core/Backends/Unmanaged/UnmanagedStorage.Slicing.cs
@@ -96,9 +96,16 @@ private UnmanagedStorage GetViewInternal(params Slice[] slices)
             if (!_shape.IsRecursive && slices.All(s => Equals(Slice.All, s)))
                 return Alias();
 
-            //handle broadcasted shape
+            //handle broadcasted shape: materialize broadcast data into contiguous memory,
+            //then slice the contiguous result. We must use a Clean() shape (not the broadcast
+            //shape) so that strides match the contiguous data layout. Using _shape.Slice(slices)
+            //would attach broadcast strides [1,0] to contiguous data [3,1], causing wrong offsets.
             if (_shape.IsBroadcasted)
-                return Clone().Alias(_shape.Slice(slices));
+            {
+                var clonedData = CloneData();
+                var cleanShape = _shape.Clean();
+                return new UnmanagedStorage(clonedData, cleanShape).GetViewInternal(slices);
+            }
 
             return Alias(_shape.Slice(slices));
         }
diff --git a/src/NumSharp.Core/NumSharp.Core.csproj b/src/NumSharp.Core/NumSharp.Core.csproj
@@ -1,6 +1,6 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <Authors>Eli Belash, Haiping Chen, Meinrad Recheis, Deepak Kumar Battini</Authors>
@@ -15,7 +15,7 @@
     <RepositoryType>git</RepositoryType>
     <PackageTags>Numpy, NumSharp, MachineLearning, Math, Scientific, Numeric, Mathlab, SciSharp</PackageTags>
     <PackageLicenseUrl></PackageLicenseUrl>
-    <LangVersion>12.0</LangVersion>
+    <LangVersion>latest</LangVersion>
     <PackageIconUrl>https://avatars3.githubusercontent.com/u/44989469?s=200&amp;v=4</PackageIconUrl>
     <PackageId>NumSharp</PackageId>
     <Product>NumSharp</Product>
@@ -79,10 +79,7 @@
     <None Include="Operations\Elementwise\Templates\Default.Op.Equals.template.cs" />
   </ItemGroup>
 
-  <ItemGroup>
-    <PackageReference Include="System.Memory" Version="4.5.5" />
-    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
-  </ItemGroup>
+  <!-- System.Memory and System.Runtime.CompilerServices.Unsafe are built into net8.0+ -->
 
   <ItemGroup>
     <Service Include="{508349b6-6b84-4df5-91f0-309beebad82d}" />
diff --git a/src/NumSharp.Core/Utilities/SteppingExtension.cs b/src/NumSharp.Core/Utilities/SteppingExtension.cs
@@ -16,8 +16,8 @@ public static T[] Step<T>(this T[] array, int step)
             if (step == 1)
                 return array;
             if (step == -1)
-                return array.Reverse().ToArray();
-            var stepped_enumerable = Step(step < 0 ? array.Reverse().GetEnumerator() : array.OfType<T>().GetEnumerator(), Math.Abs(step));
+                return array.AsEnumerable().Reverse().ToArray();
+            var stepped_enumerable = Step(step < 0 ? array.AsEnumerable().Reverse().GetEnumerator() : array.OfType<T>().GetEnumerator(), Math.Abs(step));
             return stepped_enumerable.ToArray();
         }
 
diff --git a/test/NumSharp.Benchmark/NumSharp.Benchmark.csproj b/test/NumSharp.Benchmark/NumSharp.Benchmark.csproj
@@ -2,8 +2,8 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
-    <LangVersion>12.0</LangVersion>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
+    <LangVersion>latest</LangVersion>
     <Platforms>AnyCPU;x64</Platforms>
     <ApplicationIcon />
     <Win32Resource />
@@ -18,8 +18,7 @@
     <PackageReference Include="BenchmarkDotNet" Version="0.12.1" />
     <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
     <PackageReference Include="Microsoft.Windows.Compatibility" Version="5.0.2" />
-    <PackageReference Include="System.Memory" Version="4.5.5" />
-    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
+    <!-- System.Memory and System.Runtime.CompilerServices.Unsafe are built into net8.0+ -->
   </ItemGroup>
 
   <ItemGroup>
diff --git a/test/NumSharp.ConsumePackage/NumSharp.ConsumePackage.csproj b/test/NumSharp.ConsumePackage/NumSharp.ConsumePackage.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp2.1</TargetFramework>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/test/NumSharp.Examples/NumSharp.Examples.csproj b/test/NumSharp.Examples/NumSharp.Examples.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp2.2</TargetFramework>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/test/NumSharp.Examples/ShallowWater.cs b/test/NumSharp.Examples/ShallowWater.cs
@@ -1,5 +1,5 @@
 ﻿using System;
-using NumSharp.Core;
+using NumSharp;
 using System.Collections;
 using System.Collections.Generic;
 
diff --git a/test/NumSharp.UnitTest/NumSharp.UnitTest.csproj b/test/NumSharp.UnitTest/NumSharp.UnitTest.csproj
@@ -1,10 +1,10 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-    <LangVersion>12.0</LangVersion>
+    <LangVersion>latest</LangVersion>
     <Platforms>AnyCPU</Platforms>
     <AssemblyOriginatorKeyFile>Open.snk</AssemblyOriginatorKeyFile>
     <Configurations>Debug;Release;Publish</Configurations>
@@ -37,8 +37,7 @@
     <PackageReference Include="FluentAssertions" Version="5.10.3" />
     <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
     <PackageReference Include="OpenCover" Version="4.7.922" />
-    <PackageReference Include="System.Memory" Version="4.5.5" />
-    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />	
+    <!-- System.Memory and System.Runtime.CompilerServices.Unsafe are built into net8.0+ -->
   </ItemGroup>
 
   <ItemGroup>
diff --git a/test/NumSharp.UnitTest/Utilities/SteppingOverArray.cs b/test/NumSharp.UnitTest/Utilities/SteppingOverArray.cs
@@ -33,7 +33,7 @@ public void Stepping()
             //>>>
             var a = new[] {1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
             Assert.AreSame(a, a.Step(1));
-            AssertAreEqual(new[] {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}.Reverse().ToArray(), a.Step(-1));
+            AssertAreEqual(new[] {1, 2, 3, 4, 5, 6, 7, 8, 9, 10}.AsEnumerable().Reverse().ToArray(), a.Step(-1));
             AssertAreEqual(new[] {10, 8, 6, 4, 2,}.ToArray(), a.Step(-2));
             AssertAreEqual(new[] {1, 3, 5, 7, 9,}.ToArray(), a.Step(2));
             AssertAreEqual(new[] {10, 7, 4, 1,}.ToArray(), a.Step(-3));
