Skip to content

Commit bacf59d

Browse files
committed
test(dtypes): Remove 11 stale [OpenBugs] tags for Half/Complex tests
All 11 tests pass on both frameworks (net8.0 + net10.0) after Rounds 6-15 fixes. Their [OpenBugs] attribute was filtering them out of the CI default run, hiding passing coverage. Stale tag removed along with the inaccurate "not supported yet" comments. Tests re-enabled in CI: NewDtypesArithmeticTests.cs Complex_Multiply (closed by R6) Complex_Multiply_Scalar (closed by R6) NewDtypesComparisonTests.cs Half_AsType_ToComplex (closed pre-R11) NewDtypesCumulativeTests.cs Complex_CumProd (closed by R7 / B18) NewDtypesEdgeCaseTests.cs Complex_Dot (closed by R6) NewDtypesReductionTests.cs Half_Mean (closed by R14 / B2+B16) Half_Std (closed by R14 / B16) Complex_Mean (closed by R14 / B2) Complex_Std (closed by R7 / B20) Complex_Sum_Axis (closed by R7 / B19) NewDtypesTypePromotionTests.cs Half_Plus_Complex_PromotesToComplex (closed pre-R11) Full suite: 6929 -> 6940 / 0 / 11 per framework (default CI filter).
1 parent 5415e52 commit bacf59d

6 files changed

Lines changed: 0 additions & 11 deletions

File tree

test/NumSharp.UnitTest/NewDtypes/NewDtypesArithmeticTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ public void Complex_Add()
132132
}
133133

134134
[TestMethod]
135-
[OpenBugs] // Complex multiply not supported in IL kernel yet
136135
public void Complex_Multiply()
137136
{
138137
// NumPy: z * z2 where z=[1+2j, 3+4j, 0+0j, -1-1j], z2=[1+0j, 0+1j, 1+1j, 2+2j]
@@ -149,7 +148,6 @@ public void Complex_Multiply()
149148
}
150149

151150
[TestMethod]
152-
[OpenBugs] // Complex multiply not supported in IL kernel yet
153151
public void Complex_Multiply_Scalar()
154152
{
155153
// NumPy: np.array([1+2j, 3+4j, 0+0j, -1-1j]) * 2

test/NumSharp.UnitTest/NewDtypes/NewDtypesComparisonTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@ public void Half_AsType_ToDouble()
254254
}
255255

256256
[TestMethod]
257-
[OpenBugs] // Half to Complex conversion not supported yet
258257
public void Half_AsType_ToComplex()
259258
{
260259
// NumPy: np.array([1.5, 2.5, 3.5], dtype=np.float16).astype(np.complex128)

test/NumSharp.UnitTest/NewDtypes/NewDtypesCumulativeTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ public void Complex_CumSum()
102102
}
103103

104104
[TestMethod]
105-
[OpenBugs] // CumProd not supported for Complex yet
106105
public void Complex_CumProd()
107106
{
108107
// NumPy: np.cumprod(np.array([1+1j, 2+2j, 3+3j]))

test/NumSharp.UnitTest/NewDtypes/NewDtypesEdgeCaseTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,6 @@ public void Half_Dot()
282282
}
283283

284284
[TestMethod]
285-
[OpenBugs] // Dot not supported for Complex (multiply not working)
286285
public void Complex_Dot()
287286
{
288287
// NumPy: np.dot([1+1j, 2+2j], [1-1j, 2-2j]) = (10+0j)

test/NumSharp.UnitTest/NewDtypes/NewDtypesReductionTests.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ public void Half_NanSum()
166166
}
167167

168168
[TestMethod]
169-
[OpenBugs] // Mean division not supported for Half yet
170169
public void Half_Mean()
171170
{
172171
// NumPy: np.mean(np.array([1.0, 2.0, 3.0, 4.0, 5.0], dtype=np.float16)) = 3.0 (dtype: float16)
@@ -189,7 +188,6 @@ public void Half_NanMin()
189188
}
190189

191190
[TestMethod]
192-
[OpenBugs] // Std not supported for Half yet
193191
public void Half_Std()
194192
{
195193
// NumPy: np.std(np.array([1.0, 2.0, 3.0, 4.0, 5.0], dtype=np.float16)) = 1.4140625 (dtype: float16)
@@ -235,7 +233,6 @@ public void Complex_Sum()
235233
}
236234

237235
[TestMethod]
238-
[OpenBugs] // Mean division not supported for Complex yet
239236
public void Complex_Mean()
240237
{
241238
// NumPy: np.mean(np.array([1+2j, 3+4j, 0+0j, -1-1j])) = (0.75+1.25j) (dtype: complex128)
@@ -247,7 +244,6 @@ public void Complex_Mean()
247244
}
248245

249246
[TestMethod]
250-
[OpenBugs] // Std not supported for Complex yet
251247
public void Complex_Std()
252248
{
253249
// NumPy: np.std(np.array([1+0j, 2+0j, 3+0j, 4+0j, 5+0j])) = 1.4142135623730951 (dtype: float64)
@@ -259,7 +255,6 @@ public void Complex_Std()
259255
}
260256

261257
[TestMethod]
262-
[OpenBugs] // Axis reductions not supported for Complex yet
263258
public void Complex_Sum_Axis()
264259
{
265260
// NumPy: np.sum(np.array([[1+2j, 3+4j], [5+6j, 7+8j]]), axis=0) = [6+8j, 10+12j]

test/NumSharp.UnitTest/NewDtypes/NewDtypesTypePromotionTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ public void SByte_Plus_FloatScalar_PromotesToFloat64()
7474
#region Half + Other Types
7575

7676
[TestMethod]
77-
[OpenBugs] // Half + Complex type promotion not fully supported yet
7877
public void Half_Plus_Complex_PromotesToComplex()
7978
{
8079
// NumPy: float16 + complex128 = complex128

0 commit comments

Comments
 (0)