Skip to content

Gdt40 save#813

Draft
pp-mo wants to merge 5 commits into
SciTools:mainfrom
pp-mo:gdt40_save
Draft

Gdt40 save#813
pp-mo wants to merge 5 commits into
SciTools:mainfrom
pp-mo:gdt40_save

Conversation

@pp-mo

@pp-mo pp-mo commented Jun 24, 2026

Copy link
Copy Markdown
Member

Addresses #785

So far, so highly sketchy + experimental

NOTE: I don't really like 94a3d38 because we only want to support calling without coords for the sake of the existing unit tests.
But I tried adapting some of the existing mock-ist tests + it's really quite awkward

@scitools-ci scitools-ci Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templating

This PR includes changes that may be worth sharing via templating. For each file listed below, please either:

  • Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github templates/ directory. 1
  • Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
  • Dismiss the suggestion if the changes are not suitable for templating.

You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.

Templated files

The following changed files are templated:

Footnotes

  1. Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
    @scitools-templating: please no update notification on: iris-grib

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.83333% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.83%. Comparing base (56bf257) to head (94a3d38).

Files with missing lines Patch % Lines
src/iris_grib/_save_rules.py 83.33% 8 Missing and 6 partials ⚠️
src/iris_grib/__init__.py 88.23% 1 Missing and 1 partial ⚠️
src/iris_grib/_grib2_convert.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   90.05%   89.83%   -0.23%     
==========================================
  Files          10       10              
  Lines        2564     2665     +101     
  Branches      420      438      +18     
==========================================
+ Hits         2309     2394      +85     
- Misses        156      165       +9     
- Partials       99      106       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants