Gdt40 save#813
Conversation
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Templated files
The following changed files are templated:
-
pyproject.toml, templated bySciTools/.github/templates/pyproject.toml
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris-grib↩
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
==========================================
- Coverage 90.05% 89.83% -0.23%
==========================================
Files 10 10
Lines 2564 2665 +101
Branches 420 438 +18
==========================================
+ Hits 2309 2394 +85
- Misses 156 165 +9
- Partials 99 106 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…d dim needs a dimcoord.
Addresses #785
So far, so highly sketchy + experimental
NOTE: I don't really like 94a3d38 because we only want to support calling without coords for the sake of the existing unit tests.
But I tried adapting some of the existing mock-ist tests + it's really quite awkward