cdburnerxp@4.5.8.7128: Fix installer url and checkver version#17736
cdburnerxp@4.5.8.7128: Fix installer url and checkver version#17736YusufKhalifadev wants to merge 4 commits into
Conversation
This PR fixes cdburnderxp installer url and checkver script.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe PR modifies Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 14 minutes and 16 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/cdburnerxp.json (1)
40-53: Please run the standard manifest validation flow before merge.Use:
.\bin\checkver.ps1 -App cdburnerxp -f.\bin\formatjson.ps1 -App cdburnerxpscoop install .\bucket\cdburnerxp.json -a 64bitscoop install .\bucket\cdburnerxp.json -a 32bitReferences:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/cdburnerxp.json` around lines 40 - 53, The manifest's checkver/autoupdate entries need local validation and formatting before merge: run the standard manifest validation flow using the provided commands (.\bin\checkver.ps1 -App cdburnerxp -f, .\bin\formatjson.ps1 -App cdburnerxp) and then test both architectures by installing the manifest (scoop install .\bucket\cdburnerxp.json -a 64bit and -a 32bit); ensure the "checkver.regex" (CDBurnerXP-x64-([\d.]+).zip) matches the upstream filenames and that the "autoupdate.architecture.64bit.url" and ".32bit.url" templates resolve correctly to the expected SourceForge artifacts, fix the regex or URLs if validation or installs fail, then reformat and commit the updated cdburnerxp.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/cdburnerxp.json`:
- Line 42: The checkver regex in the manifest uses
"CDBurnerXP-x64-([\\d.]+).zip" which leaves the dot before zip unescaped and can
match any character; update the regex (in the manifest key "regex") to escape
the dot as "\\.zip" so it exactly matches the ".zip" extension (i.e., change the
pattern to "CDBurnerXP-x64-([\\d.]+)\\.zip").
---
Nitpick comments:
In `@bucket/cdburnerxp.json`:
- Around line 40-53: The manifest's checkver/autoupdate entries need local
validation and formatting before merge: run the standard manifest validation
flow using the provided commands (.\bin\checkver.ps1 -App cdburnerxp -f,
.\bin\formatjson.ps1 -App cdburnerxp) and then test both architectures by
installing the manifest (scoop install .\bucket\cdburnerxp.json -a 64bit and -a
32bit); ensure the "checkver.regex" (CDBurnerXP-x64-([\d.]+).zip) matches the
upstream filenames and that the "autoupdate.architecture.64bit.url" and
".32bit.url" templates resolve correctly to the expected SourceForge artifacts,
fix the regex or URLs if validation or installs fail, then reformat and commit
the updated cdburnerxp.json.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bd899c8a-de8a-4082-8c10-678760d89ac5
📒 Files selected for processing (1)
bucket/cdburnerxp.json
This PR fixes the cdburnderxp installer URL and checkver script.
Why I did these changes is because of the installer url not working by using the checkurls script it shows that this manifest installer url is unreachable.
Test:

<manifest-name[@version]|chore>: <general summary of the pull request>