Skip to content

cdburnerxp@4.5.8.7128: Fix installer url and checkver version#17736

Open
YusufKhalifadev wants to merge 4 commits into
ScoopInstaller:masterfrom
YusufKhalifadev:fix/cdburnerxp-url
Open

cdburnerxp@4.5.8.7128: Fix installer url and checkver version#17736
YusufKhalifadev wants to merge 4 commits into
ScoopInstaller:masterfrom
YusufKhalifadev:fix/cdburnerxp-url

Conversation

@YusufKhalifadev
Copy link
Copy Markdown
Contributor

@YusufKhalifadev YusufKhalifadev commented May 1, 2026

This PR fixes the cdburnderxp installer URL and checkver script.

Why I did these changes is because of the installer url not working by using the checkurls script it shows that this manifest installer url is unreachable.

Test:
image

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

This PR fixes cdburnderxp installer url and checkver script.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1e0cd1de-2f0a-43ec-ae31-04a25694de39

📥 Commits

Reviewing files that changed from the base of the PR and between b4a5b39 and 1d2c7d2.

📒 Files selected for processing (1)
  • bucket/cdburnerxp.json
✅ Files skipped from review due to trivial changes (1)
  • bucket/cdburnerxp.json

📝 Walkthrough

Walkthrough

The PR modifies bucket/cdburnerxp.json to switch binary sources from Fosshub to SourceForge for both 64-bit and 32-bit builds. It updates download url values and replaces integrity hash entries (new sha1: values). checkver is changed to use SourceForge archive filename parsing with a new regex and sets sourceforge: "cdburnerxp". Autoupdate url templates for both architectures are updated to SourceForge file URLs using the $version placeholder.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: fixing the installer URL and checkver version for cdburnerxp, which directly aligns with the changeset.
Description check ✅ Passed The description explains the rationale for changes and includes test evidence, though it could be more detailed about the specific changes made to the manifest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 6/8 reviews remaining, refill in 14 minutes and 16 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@YusufKhalifadev YusufKhalifadev changed the title cdburnerxp: Fix installer url and checkver version 4.5.8.7128 cdburnerxp@4.5.8.7128: Fix installer url and checkver version May 1, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/cdburnerxp.json (1)

40-53: Please run the standard manifest validation flow before merge.

Use:

  • .\bin\checkver.ps1 -App cdburnerxp -f
  • .\bin\formatjson.ps1 -App cdburnerxp
  • scoop install .\bucket\cdburnerxp.json -a 64bit
  • scoop install .\bucket\cdburnerxp.json -a 32bit

References:

As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/cdburnerxp.json` around lines 40 - 53, The manifest's
checkver/autoupdate entries need local validation and formatting before merge:
run the standard manifest validation flow using the provided commands
(.\bin\checkver.ps1 -App cdburnerxp -f, .\bin\formatjson.ps1 -App cdburnerxp)
and then test both architectures by installing the manifest (scoop install
.\bucket\cdburnerxp.json -a 64bit and -a 32bit); ensure the "checkver.regex"
(CDBurnerXP-x64-([\d.]+).zip) matches the upstream filenames and that the
"autoupdate.architecture.64bit.url" and ".32bit.url" templates resolve correctly
to the expected SourceForge artifacts, fix the regex or URLs if validation or
installs fail, then reformat and commit the updated cdburnerxp.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/cdburnerxp.json`:
- Line 42: The checkver regex in the manifest uses
"CDBurnerXP-x64-([\\d.]+).zip" which leaves the dot before zip unescaped and can
match any character; update the regex (in the manifest key "regex") to escape
the dot as "\\.zip" so it exactly matches the ".zip" extension (i.e., change the
pattern to "CDBurnerXP-x64-([\\d.]+)\\.zip").

---

Nitpick comments:
In `@bucket/cdburnerxp.json`:
- Around line 40-53: The manifest's checkver/autoupdate entries need local
validation and formatting before merge: run the standard manifest validation
flow using the provided commands (.\bin\checkver.ps1 -App cdburnerxp -f,
.\bin\formatjson.ps1 -App cdburnerxp) and then test both architectures by
installing the manifest (scoop install .\bucket\cdburnerxp.json -a 64bit and -a
32bit); ensure the "checkver.regex" (CDBurnerXP-x64-([\d.]+).zip) matches the
upstream filenames and that the "autoupdate.architecture.64bit.url" and
".32bit.url" templates resolve correctly to the expected SourceForge artifacts,
fix the regex or URLs if validation or installs fail, then reformat and commit
the updated cdburnerxp.json.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bd899c8a-de8a-4082-8c10-678760d89ac5

📥 Commits

Reviewing files that changed from the base of the PR and between aa0a496 and b4a5b39.

📒 Files selected for processing (1)
  • bucket/cdburnerxp.json

Comment thread bucket/cdburnerxp.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant