Skip to content

pyglossary: Add version 5.4.1#17782

Open
scillidan wants to merge 7 commits into
ScoopInstaller:masterfrom
scillidan:pyglossary
Open

pyglossary: Add version 5.4.1#17782
scillidan wants to merge 7 commits into
ScoopInstaller:masterfrom
scillidan:pyglossary

Conversation

@scillidan

Copy link
Copy Markdown
Contributor

Closes #17781

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 9, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates the PyGlossary Scoop manifest to version 5.4.1, refreshes the top-level metadata, changes the Windows x64 download URL and hash, keeps the bin and Start Menu shortcut mappings, and retains the GitHub-based checkver and $version-templated autoupdate URL.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, specific, and matches the main change: adding PyGlossary version 5.4.1.
Description check ✅ Passed The description includes the linked issue and the required checklist items from the template.
Linked Issues check ✅ Passed The manifest update to 5.4.1 and refreshed download hash/URL satisfy the package request criteria.
Out of Scope Changes check ✅ Passed The changes are limited to the PyGlossary manifest update and related release metadata.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/pyglossary.json (1)

1-27: Local manifest validation steps before merge

Please run the standard Scoop checks for this new manifest:

scoop config debug true
scoop config gh_token <your-github-token>   # read-only token
.\bin\checkver.ps1 -App pyglossary -f
.\bin\formatjson.ps1 -App pyglossary
scoop install .\bucket\pyglossary.json -a 64bit

If anything is unclear, reference:

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/pyglossary.json` around lines 1 - 27, Run the standard local Scoop
manifest validation for the new pyglossary.json manifest: enable debug (scoop
config debug true), set a read-only GitHub token (scoop config gh_token), then
run the checkver script for the App (.\bin\checkver.ps1 -App pyglossary -f), run
the formatter (.\bin\formatjson.ps1 -App pyglossary), and attempt a local
install to validate the package and architecture-specific fields (scoop install
.\bucket\pyglossary.json -a 64bit); while doing this, verify the "hash" value
under "architecture" matches the downloaded artifact, confirm "bin" and
"shortcuts" entries point to the packaged pyglossary.exe, and ensure "checkver"
and "autoupdate" URL patterns correctly use $version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/pyglossary.json`:
- Line 5: Replace the non-canonical SPDX string used in the JSON license field:
locate the "license" key where it is set to "GPL-3-or-later" and update its
value to the canonical SPDX identifier "GPL-3.0-or-later" so the manifest uses
the standard SPDX form.

---

Nitpick comments:
In `@bucket/pyglossary.json`:
- Around line 1-27: Run the standard local Scoop manifest validation for the new
pyglossary.json manifest: enable debug (scoop config debug true), set a
read-only GitHub token (scoop config gh_token), then run the checkver script for
the App (.\bin\checkver.ps1 -App pyglossary -f), run the formatter
(.\bin\formatjson.ps1 -App pyglossary), and attempt a local install to validate
the package and architecture-specific fields (scoop install
.\bucket\pyglossary.json -a 64bit); while doing this, verify the "hash" value
under "architecture" matches the downloaded artifact, confirm "bin" and
"shortcuts" entries point to the packaged pyglossary.exe, and ensure "checkver"
and "autoupdate" URL patterns correctly use $version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 277bd689-14f9-4684-9654-837dd400d425

📥 Commits

Reviewing files that changed from the base of the PR and between f498224 and 88cfd27.

📒 Files selected for processing (1)
  • bucket/pyglossary.json

Comment thread bucket/pyglossary.json Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@scillidan

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

pyglossary

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

arvdk added a commit to arvdk/Extras that referenced this pull request Jun 9, 2026
@scillidan scillidan changed the title pyglossary: Add version 5.3.0 pyglossary: Add version 5.4.1 Jun 24, 2026
@scillidan

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

Invalid manifests

  • pyglossary

Check the full log for details.

@scillidan

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

pyglossary

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: PyGlossary

1 participant