pyglossary: Add version 5.3.0#17782
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a new Scoop Extras manifest for PyGlossary v5.3.0: manifest root metadata (version, description, homepage, license), a Windows x64 download entry with SHA256, executable Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/pyglossary.json (1)
1-27: Local manifest validation steps before mergePlease run the standard Scoop checks for this new manifest:
scoop config debug true scoop config gh_token <your-github-token> # read-only token .\bin\checkver.ps1 -App pyglossary -f .\bin\formatjson.ps1 -App pyglossary scoop install .\bucket\pyglossary.json -a 64bitIf anything is unclear, reference:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- App Manifests Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/pyglossary.json` around lines 1 - 27, Run the standard local Scoop manifest validation for the new pyglossary.json manifest: enable debug (scoop config debug true), set a read-only GitHub token (scoop config gh_token), then run the checkver script for the App (.\bin\checkver.ps1 -App pyglossary -f), run the formatter (.\bin\formatjson.ps1 -App pyglossary), and attempt a local install to validate the package and architecture-specific fields (scoop install .\bucket\pyglossary.json -a 64bit); while doing this, verify the "hash" value under "architecture" matches the downloaded artifact, confirm "bin" and "shortcuts" entries point to the packaged pyglossary.exe, and ensure "checkver" and "autoupdate" URL patterns correctly use $version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/pyglossary.json`:
- Line 5: Replace the non-canonical SPDX string used in the JSON license field:
locate the "license" key where it is set to "GPL-3-or-later" and update its
value to the canonical SPDX identifier "GPL-3.0-or-later" so the manifest uses
the standard SPDX form.
---
Nitpick comments:
In `@bucket/pyglossary.json`:
- Around line 1-27: Run the standard local Scoop manifest validation for the new
pyglossary.json manifest: enable debug (scoop config debug true), set a
read-only GitHub token (scoop config gh_token), then run the checkver script for
the App (.\bin\checkver.ps1 -App pyglossary -f), run the formatter
(.\bin\formatjson.ps1 -App pyglossary), and attempt a local install to validate
the package and architecture-specific fields (scoop install
.\bucket\pyglossary.json -a 64bit); while doing this, verify the "hash" value
under "architecture" matches the downloaded artifact, confirm "bin" and
"shortcuts" entries point to the packaged pyglossary.exe, and ensure "checkver"
and "autoupdate" URL patterns correctly use $version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 277bd689-14f9-4684-9654-837dd400d425
📒 Files selected for processing (1)
bucket/pyglossary.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
/verify |
|
All changes look good. Wait for review from human collaborators. pyglossary
|
Closes #17781
<manifest-name[@version]|chore>: <general summary of the pull request>