Skip to content

pyglossary: Add version 5.3.0#17782

Open
scillidan wants to merge 2 commits into
ScoopInstaller:masterfrom
scillidan:pyglossary
Open

pyglossary: Add version 5.3.0#17782
scillidan wants to merge 2 commits into
ScoopInstaller:masterfrom
scillidan:pyglossary

Conversation

@scillidan
Copy link
Copy Markdown
Contributor

Closes #17781

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d5f6b342-52c8-4966-ba36-899b69358655

📥 Commits

Reviewing files that changed from the base of the PR and between 88cfd27 and 907fa43.

📒 Files selected for processing (1)
  • bucket/pyglossary.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/pyglossary.json

📝 Walkthrough

Walkthrough

This PR adds a new Scoop Extras manifest for PyGlossary v5.3.0: manifest root metadata (version, description, homepage, license), a Windows x64 download entry with SHA256, executable bin and Start Menu shortcut, and GitHub-based checkver plus an autoupdate URL template using $version.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and directly describes the main change: adding PyGlossary version 5.3.0 to the manifest.
Description check ✅ Passed The description includes the required checklist with both items completed and references the closed issue #17781, meeting the template requirements.
Linked Issues check ✅ Passed The pull request adds PyGlossary v5.3.0 manifest as requested in issue #17781, meeting all specified criteria including popularity, stability, and standard installation requirements.
Out of Scope Changes check ✅ Passed All changes are scoped to adding the PyGlossary 5.3.0 manifest file; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/pyglossary.json (1)

1-27: Local manifest validation steps before merge

Please run the standard Scoop checks for this new manifest:

scoop config debug true
scoop config gh_token <your-github-token>   # read-only token
.\bin\checkver.ps1 -App pyglossary -f
.\bin\formatjson.ps1 -App pyglossary
scoop install .\bucket\pyglossary.json -a 64bit

If anything is unclear, reference:

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/pyglossary.json` around lines 1 - 27, Run the standard local Scoop
manifest validation for the new pyglossary.json manifest: enable debug (scoop
config debug true), set a read-only GitHub token (scoop config gh_token), then
run the checkver script for the App (.\bin\checkver.ps1 -App pyglossary -f), run
the formatter (.\bin\formatjson.ps1 -App pyglossary), and attempt a local
install to validate the package and architecture-specific fields (scoop install
.\bucket\pyglossary.json -a 64bit); while doing this, verify the "hash" value
under "architecture" matches the downloaded artifact, confirm "bin" and
"shortcuts" entries point to the packaged pyglossary.exe, and ensure "checkver"
and "autoupdate" URL patterns correctly use $version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/pyglossary.json`:
- Line 5: Replace the non-canonical SPDX string used in the JSON license field:
locate the "license" key where it is set to "GPL-3-or-later" and update its
value to the canonical SPDX identifier "GPL-3.0-or-later" so the manifest uses
the standard SPDX form.

---

Nitpick comments:
In `@bucket/pyglossary.json`:
- Around line 1-27: Run the standard local Scoop manifest validation for the new
pyglossary.json manifest: enable debug (scoop config debug true), set a
read-only GitHub token (scoop config gh_token), then run the checkver script for
the App (.\bin\checkver.ps1 -App pyglossary -f), run the formatter
(.\bin\formatjson.ps1 -App pyglossary), and attempt a local install to validate
the package and architecture-specific fields (scoop install
.\bucket\pyglossary.json -a 64bit); while doing this, verify the "hash" value
under "architecture" matches the downloaded artifact, confirm "bin" and
"shortcuts" entries point to the packaged pyglossary.exe, and ensure "checkver"
and "autoupdate" URL patterns correctly use $version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 277bd689-14f9-4684-9654-837dd400d425

📥 Commits

Reviewing files that changed from the base of the PR and between f498224 and 88cfd27.

📒 Files selected for processing (1)
  • bucket/pyglossary.json

Comment thread bucket/pyglossary.json Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@scillidan
Copy link
Copy Markdown
Contributor Author

/verify

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

All changes look good.

Wait for review from human collaborators.

pyglossary

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: PyGlossary

1 participant