weasel: Add version 0.17.4#17826
Open
scillidan wants to merge 2 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request adds bucket/weasel.json, a new Scoop package manifest for Weasel (Rime Input Method Engine) version 0.17.4. The manifest includes package metadata (description, homepage, license), a download URL and SHA-256 hash for the 64-bit installer, pre-installation cleanup to remove the plugins directory, a desktop shortcut configuration, GitHub-based version checking, and an autoupdate URL template. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/weasel.json (1)
1-30: Run the standard Scoop manifest validation flow before merge.scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App weasel -f .\bin\formatjson.ps1 -App weasel scoop install .\bucket\weasel.json -a 64bitAs per coding guidelines: “Provide clear instructions for testing the manifest locally before submission.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/weasel.json` around lines 1 - 30, Run the standard Scoop manifest validation steps locally and fix any issues before merging: set scoop debug and a GH token, then run the checkver and formatjson flows and attempt a local 64-bit install to validate hashes and URLs; specifically verify the "checkver" entry, the "autoupdate" template (architecture.64bit.url and $buildVersion handling), the installer URL/hash under "architecture.64bit.url" and "hash", and the PowerShell quoting in "pre_install" so the removal command works as expected. Ensure you execute the recommended commands (debug true, gh_token, .\bin\checkver.ps1 -App weasel -f, .\bin\formatjson.ps1 -App weasel, scoop install .\bucket\weasel.json -a 64bit) and fix any validation errors reported.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/weasel.json`:
- Around line 19-26: Autoupdate URL uses an undefined $buildVersion
(checkver.github only provides $version), so update the autoupdate.url to
hardcode the fourth segment (".0") to match release assets; specifically modify
the autoupdate -> architecture -> 64bit -> url string (and any other platform
urls) to use weasel-$version.0-installer.exe#/dl.7z instead of
weasel-$version.$buildVersion-installer.exe#/dl.7z so autoupdate generates a
valid asset URL.
---
Nitpick comments:
In `@bucket/weasel.json`:
- Around line 1-30: Run the standard Scoop manifest validation steps locally and
fix any issues before merging: set scoop debug and a GH token, then run the
checkver and formatjson flows and attempt a local 64-bit install to validate
hashes and URLs; specifically verify the "checkver" entry, the "autoupdate"
template (architecture.64bit.url and $buildVersion handling), the installer
URL/hash under "architecture.64bit.url" and "hash", and the PowerShell quoting
in "pre_install" so the removal command works as expected. Ensure you execute
the recommended commands (debug true, gh_token, .\bin\checkver.ps1 -App weasel
-f, .\bin\formatjson.ps1 -App weasel, scoop install .\bucket\weasel.json -a
64bit) and fix any validation errors reported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e029890a-623f-4acc-816d-dfd296414a6a
📒 Files selected for processing (1)
bucket/weasel.json
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. weasel
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17825
<manifest-name[@version]|chore>: <general summary of the pull request>