lmstudio: Add version 0.4.13-1#17841
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019e4672-5efa-727b-8af8-98a820818b46 Co-authored-by: Amp <amp@ampcode.com>
📝 WalkthroughWalkthroughThis pull request adds Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/lmstudio.json (1)
29-43: Local validation checklist to include in your final verification notes.Please run/confirm:
.\bin\checkver.ps1 -App lmstudio -f.\bin\formatjson.ps1 -App lmstudioscoop install .\bucket\lmstudio.json -a 64bitscoop install .\bucket\lmstudio.json -a arm64If release automation uses GitHub API elsewhere, optionally set:
scoop config debug truescoop config gh_token <read-only-token>As per coding guidelines: “Provide clear instructions for testing the manifest locally before submission.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/lmstudio.json` around lines 29 - 43, Add the required local validation checklist to the submission (e.g., PR description or a verificationNotes field associated with bucket/lmstudio.json): include the exact commands to run (.\\bin\\checkver.ps1 -App lmstudio -f, .\\bin\\formatjson.ps1 -App lmstudio, scoop install .\\bucket\\lmstudio.json -a 64bit, scoop install .\\bucket\\lmstudio.json -a arm64) and the optional release-automation hints (scoop config debug true and scoop config gh_token <read-only-token>) so reviewers can reproduce local testing; ensure the checklist is clearly labeled and placed alongside the lmstudio.json changes for easy verification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/lmstudio.json`:
- Line 3: This new manifest (lmstudio.json) lacks a linked package-request
issue; before merge update the PR body to include a package-request issue
reference (e.g., “#123” or the full GitHub issue URL) and, if helpful, add the
same link in the PR description near the manifest mention; ensure the linked
request satisfies Extras acceptance criteria (well-known app, stable release,
English UI/docs, and installer-extraction compatibility with Scoop) and use the
provided package-request template URL if you need to create the issue.
---
Nitpick comments:
In `@bucket/lmstudio.json`:
- Around line 29-43: Add the required local validation checklist to the
submission (e.g., PR description or a verificationNotes field associated with
bucket/lmstudio.json): include the exact commands to run (.\\bin\\checkver.ps1
-App lmstudio -f, .\\bin\\formatjson.ps1 -App lmstudio, scoop install
.\\bucket\\lmstudio.json -a 64bit, scoop install .\\bucket\\lmstudio.json -a
arm64) and the optional release-automation hints (scoop config debug true and
scoop config gh_token <read-only-token>) so reviewers can reproduce local
testing; ensure the checklist is clearly labeled and placed alongside the
lmstudio.json changes for easy verification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d1f82c81-dece-4fec-82b6-debdc040c18b
📒 Files selected for processing (1)
bucket/lmstudio.json
Closes #17842
New manifest:
lmstudioAdds a manifest for LM Studio — a desktop app to discover, download, and run local LLMs (llama.cpp, MLX, etc.) with a chat UI and OpenAI-compatible local API server.
Extras acceptance criteria
#/dl.7z+Expand-7zipArchive $PLUGINSDIR\app-*.7zpattern assignal.Manifest details
64bitandarm64LM Studiolms(LM Studio CLI, shipped atresources\app\.webpack\lms.exe)versionandbuildand joins them withreplace: ""-"")Validation
bin\formatjson.ps1 -App lmstudio— OKbin\checkurls.ps1 -App lmstudio— 2/2 URLs OKbin\checkver.ps1 -App lmstudio -Update -ForceUpdate— version + both hashes resolved correctlyscoop installandscoop uninstalltested locally on Windows 11 x64;LM Studio.exelaunches,lmsshim works, start-menu shortcut created and removed cleanly