Skip to content

floral-notepaper: Add version 1.0.4#17883

Open
JackieJK wants to merge 3 commits into
ScoopInstaller:masterfrom
JackieJK:master
Open

floral-notepaper: Add version 1.0.4#17883
JackieJK wants to merge 3 commits into
ScoopInstaller:masterfrom
JackieJK:master

Conversation

@JackieJK

@JackieJK JackieJK commented May 25, 2026

Copy link
Copy Markdown
Contributor

add floral-notepaper #17962

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7c62987a-f91d-4f64-b286-f1c45bd2c794

📥 Commits

Reviewing files that changed from the base of the PR and between d0e329c and 8ae21e2.

📒 Files selected for processing (1)
  • bucket/floral-notepaper.json
✅ Files skipped from review due to trivial changes (1)
  • bucket/floral-notepaper.json

📝 Walkthrough

Walkthrough

This PR adds a new Scoop bucket manifest file bucket/floral-notepaper.json for Floral Notepaper v1.0.4. The manifest includes app metadata, a WebView2 suggestion, a 64-bit installer download URL with #/floral-notepaper.exe, the installer SHA256 hash, a desktop shortcut entry for floral-notepaper.exe, and an autoupdate URL template using $version.
Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too terse and omits the required issue link, similar-issues confirmation, and a general summary. Add a brief summary, a Closes/Relates issue reference, and the required confirmation about searching similar issues/PRs.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the repository's conventional manifest-version format and clearly summarizes the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label May 25, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/floral-notepaper.json (1)

1-26: Run the standard local manifest validation before merge.

Use the following commands locally (replace floral-notepaper as needed):

scoop config debug true
scoop config gh_token <your-github-token>  # read-only

.\bin\checkver.ps1 -App floral-notepaper -f
.\bin\formatjson.ps1 -App floral-notepaper
scoop install .\bucket\floral-notepaper.json -a 64bit

If anything fails, refer to:

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/floral-notepaper.json` around lines 1 - 26, Run the standard local
manifest validation and fix any issues in the floral-notepaper.json manifest:
enable Scoop debug and set GH token, then run .\bin\checkver.ps1 -App
floral-notepaper -f and .\bin\formatjson.ps1 -App floral-notepaper to validate
and format the JSON, and finally install locally with scoop install
.\bucket\floral-notepaper.json -a 64bit; address any errors reported (e.g.,
incorrect URLs, hash mismatch, missing fields like
version/checkver/autoupdate/architecture or malformed shortcuts) and update the
corresponding keys (version, architecture.64bit.url, architecture.64bit.hash,
checkver, autoupdate) in floral-notepaper.json until all commands succeed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/floral-notepaper.json`:
- Line 3: This new manifest lacks a linked package-request issue; update the
manifest's "description" field or the PR body to include a URL to the
package-request GitHub issue (create one if needed) and confirm the issue meets
acceptance criteria (well-known usage, stable release, English interface/docs);
specifically, add the package-request link referencing the floral-notepaper.json
manifest's description field so reviewers can verify the request and acceptance
criteria.

---

Nitpick comments:
In `@bucket/floral-notepaper.json`:
- Around line 1-26: Run the standard local manifest validation and fix any
issues in the floral-notepaper.json manifest: enable Scoop debug and set GH
token, then run .\bin\checkver.ps1 -App floral-notepaper -f and
.\bin\formatjson.ps1 -App floral-notepaper to validate and format the JSON, and
finally install locally with scoop install .\bucket\floral-notepaper.json -a
64bit; address any errors reported (e.g., incorrect URLs, hash mismatch, missing
fields like version/checkver/autoupdate/architecture or malformed shortcuts) and
update the corresponding keys (version, architecture.64bit.url,
architecture.64bit.hash, checkver, autoupdate) in floral-notepaper.json until
all commands succeed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 402c3d43-f66b-4ee8-b9ad-3649cab5224c

📥 Commits

Reviewing files that changed from the base of the PR and between 14d7ef7 and b4c9c05.

📒 Files selected for processing (1)
  • bucket/floral-notepaper.json

Comment thread bucket/floral-notepaper.json
@JackieJK JackieJK changed the title add floral-notepaper floral-notepaper: Add version v1.0.4 May 25, 2026
@arvdk

arvdk commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

I tried to install and this is what I found:

Unable to save shortcut, probably due to the 花笺 characters. ❌
Unable to save shortcut "C:\Users\WDAGUtilityAccount\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Scoop Apps\??.lnk".

I tried to start the .exe manually and got an error ❌
Could not find the WebView2 Runtime. If that is a dependency, you should add that to the manifest.

After running scoop install webview2, the application did start, but all in Chinese. After a short search, I managed to switch to English and most text got translated. ✅

My advice:

  • Change the shortcut to English.
  • Add webview2 under 'depends' in the manifest.

@JackieJK

JackieJK commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

floral-notepaper

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@aliesbelik aliesbelik linked an issue Jun 8, 2026 that may be closed by this pull request
6 tasks
@aliesbelik aliesbelik removed the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label Jun 8, 2026
@aliesbelik aliesbelik changed the title floral-notepaper: Add version v1.0.4 floral-notepaper: Add version 1.0.4 Jun 8, 2026
arvdk added a commit to arvdk/Extras that referenced this pull request Jun 9, 2026
@JackieJK JackieJK marked this pull request as draft June 29, 2026 13:01
@JackieJK JackieJK marked this pull request as ready for review July 9, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: floral-notepaper

3 participants