Skip to content

npcap-np: Add version 1.88#585

Open
scillidan wants to merge 3 commits into
ScoopInstaller:masterfrom
scillidan:npcap-np
Open

npcap-np: Add version 1.88#585
scillidan wants to merge 3 commits into
ScoopInstaller:masterfrom
scillidan:npcap-np

Conversation

@scillidan
Copy link
Copy Markdown
Contributor

@scillidan scillidan commented May 9, 2026

Relates to (Closed) [Request] npcap

Summary by CodeRabbit

  • New Features

    • Added Npcap 1.88 support with installation, silent uninstallation, and automatic update checking.
    • Installer enforces admin privileges and warns if uninstaller is missing.
  • Chores

    • Added package metadata and update configuration to enable streamlined install/uninstall/update workflows.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Warning

Rate limit exceeded

@scillidan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 23 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9a295230-813a-448b-a091-a7f19558be5a

📥 Commits

Reviewing files that changed from the base of the PR and between 9c37b54 and 02c5270.

📒 Files selected for processing (1)
  • bucket/npcap-np.json

Walkthrough

Adds a new Scoop bucket manifest bucket/npcap-np.json for Npcap 1.88 with package metadata, installer URL and SHA-256, admin checks for install/uninstall, a PowerShell uninstaller, and checkver/autoupdate rules.

Changes

Npcap Package Manifest

Layer / File(s) Summary
Manifest Configuration
bucket/npcap-np.json
Defines Npcap 1.88 package metadata, installer download URL and SHA-256, pre_install/pre_uninstall admin checks, PowerShell uninstall calling C:\Program Files\Npcap\uninstall.exe /S (warns if missing), and checkver/autoupdate rules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 In a bucket a manifest hops into sight,
Npcap bundled up tidy and light.
Hashes aligned and uninstall set free,
I nibble a carrot and cheer, whee! 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding version 1.88 of the npcap-np package.
Description check ✅ Passed The description includes the required link to the related issue and confirms the contributing guide was read, meeting the template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/npcap-np.json`:
- Around line 18-23: Replace the hardcoded "C:\\Program Files\\Npcap" path with
the environment-aware ProgramFiles variable: update the $uninstaller assignment
and any path checks that reference "C:\\Program Files\\Npcap" to use
$env:ProgramFiles (e.g., build the path from $env:ProgramFiles and "Npcap");
ensure the Start-Process and Test-Path use that $uninstaller variable and keep
the existing warn message unchanged.
- Line 20: The uninstall command string "Start-Process -FilePath $uninstaller
-ArgumentList '/S' -Wait" can return non-zero without failing; change it to
start the process with -PassThru (e.g., assign to $proc), wait for it, then
inspect $proc.ExitCode and abort/exit when ExitCode -ne 0 so uninstall failures
aren't treated as success. Update the command in the JSON (the line containing
Start-Process) to capture the process object and enforce failure handling (throw
or exit with the non-zero code) when ExitCode is non-zero.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 154485e3-b904-481a-88cd-3b9af388012b

📥 Commits

Reviewing files that changed from the base of the PR and between ec75d4c and 5e49278.

📒 Files selected for processing (1)
  • bucket/npcap-np.json

Comment thread bucket/npcap-np.json Outdated
Comment thread bucket/npcap-np.json Outdated
scillidan and others added 2 commits May 9, 2026 09:46
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@scillidan
Copy link
Copy Markdown
Contributor Author

/verify

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

All changes look good.

Wait for review from human collaborators.

npcap-np

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant