llama.cpp-cu(124|131)-dll: Add version b8763#2762
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughTwo new Scoop package manifest files are added for the llama.cpp CUDA runtime DLL distributions. These manifests define version information, download locations, integrity hashes, and automated update mechanisms for CUDA 12.4 and 13.1 Windows x64 packages, including PATH environment variable configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with llama.cpp-cu124-dlls
llama.cpp-cu131-dlls
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/llama.cpp-cu124-dlls.json`:
- Line 9: Replace the MD5-based integrity string with a SHA-256 one by computing
the archive's SHA-256 digest and updating the "hash" value from the current
"md5:6463c73b52a1edaab0f21ccd48a898e5" to the form "sha256:<hex‑digest>"; update
any validation/consumer logic that expects the "md5:" prefix (e.g. code that
parses the "hash" field) to accept the "sha256:" prefix so verification still
works with the new algorithm.
- Line 2: The manifest "version" field currently uses "12.4" but the checkver
regex captures release tags like b8340 and the autoupdate template injects
$version into the GitHub release URL; update the "version" value to match the
checkver tag format (e.g., "b8340") so it aligns with the checkver regex and
produces valid /releases/download/$version/... URLs, or alternatively adjust the
checkver pattern to extract the numeric form you want—ensure the manifest
"version" key and the checkver capture group produce the same string format used
by the autoupdate template.
In `@bucket/llama.cpp-cu131-dlls.json`:
- Line 9: The "hash" field currently uses an MD5 fingerprint
("md5:97d68e98707c7d0e75d8b30a143d6dbf"); update that value to a SHA-256 hash
and change the prefix to "sha256:" so the JSON entry uses SHA-256 integrity
(replace the entire "hash" string value for the same asset with its SHA-256 hex
digest, e.g. "sha256:<sha256-hex>").
- Line 2: The package metadata has "version": "13.1" which doesn't match the
checkver regex /releases\/tag\/(b[\d]+)/ and causes autoupdate to generate the
wrong download URL; change the "version" value to "b8340" so it matches the
checkver capture group and aligns with the hard-coded download URL (ensure the
"version" key in llama.cpp-cu131-dlls.json is updated to b8340 so autoupdate
produces the correct releases/download/b8340/... URL).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9f3b730c-be9f-4e7c-8550-ecffa0e3e88d
📒 Files selected for processing (2)
bucket/llama.cpp-cu124-dlls.jsonbucket/llama.cpp-cu131-dlls.json
z-Fng
changed the title
z-Fng
changed the title
Member
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. llama.cpp-cu124-dll
llama.cpp-cu131-dll
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added small CUDA DLLs archives from llama.cpp repository for CUDA 12.4 and 13.1 versions.
Summary by CodeRabbit