Skip to content

wezterm-nightly: Add checkver/autoupdate, bump to 20260405-c53ca64#2786

Closed
ycookiey wants to merge 1 commit intoScoopInstaller:masterfrom
ycookiey:wezterm-nightly-checkver
Closed

wezterm-nightly: Add checkver/autoupdate, bump to 20260405-c53ca64#2786
ycookiey wants to merge 1 commit intoScoopInstaller:masterfrom
ycookiey:wezterm-nightly-checkver

Conversation

@ycookiey
Copy link
Copy Markdown

@ycookiey ycookiey commented Apr 5, 2026

The wezterm-nightly manifest lacks checkver/autoupdate, so it has not been automatically updated since 2025-12-20 (#2646). This adds script-based checkver using the GitHub API updated_at field, mirroring the goneovim-nightly pattern (#725, #2541).

Closes #2785

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

Chores

  • Updated package manifest version format from a generic identifier to a dated commit-based versioning scheme for better tracking
  • Added cryptographic hash verification for 64-bit Windows package downloads to ensure download integrity and authenticity
  • Implemented automated update detection that periodically checks for new releases and manages associated metadata for seamless updates

Copilot AI review requested due to automatic review settings April 5, 2026 10:23
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 5, 2026

Walkthrough

Updated the wezterm-nightly manifest to enable automatic version checking and updates. Changed the static version string to a dated format, added a hash for integrity verification, and introduced checkver and autoupdate configurations that query GitHub's nightly releases API.

Changes

Cohort / File(s) Summary
Manifest Configuration
bucket/wezterm-nightly.json
Updated version from generic "nightly" to dated format "20260405-c53ca64". Added 64bit Windows hash for integrity validation. Introduced checkver section querying GitHub releases API with custom script parsing, and autoupdate section for automated 64bit URL updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

Suggested labels

review-needed

Poem

🐰 Hops with joy

No more stale nightly builds to fret,
GitHub API, our updates met!
Checkver and autoupdate align,
Wezterm stays fresh—perfectly fine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: adding checkver/autoupdate functionality and bumping the version to a dated commit hash.
Description check ✅ Passed The description follows the template with issue reference, conventional PR title confirmation, and contributing guide acknowledgment. It explains the problem and solution clearly.
Linked Issues check ✅ Passed The PR addresses all requirements from issue #2785: adds checkver using GitHub API updated_at field, adds autoupdate, and bumps version to a newer nightly (20260405-c53ca64).
Out of Scope Changes check ✅ Passed All changes are within scope: only modifications to wezterm-nightly.json manifest file directly addressing the checkver/autoupdate gap identified in issue #2785.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds automated version checking and autoupdate support for wezterm-nightly so Excavator/Scoop can keep the manifest current again, and bumps the manifest to the latest nightly build referenced in the PR.

Changes:

  • Bump wezterm-nightly version to 20260405-c53ca64 and update the nightly ZIP SHA256.
  • Add checkver using the GitHub Releases API (updated_at + target_commitish) following the established nightly pattern.
  • Add autoupdate so checkver -u / Excavator can rewrite the manifest as new nightlies are published.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/wezterm-nightly.json (1)

44-58: Refactor suggestion: Consider truncating commit hash explicitly for clarity.

The current implementation works correctly—target_commitish returns the full 40-character SHA, and the regex (?<version>^\d{8}-[0-9a-f]{7}) implicitly extracts the first 7 characters when matching (e.g., from 20260405-c53ca64c33d1658602b9a3aaa412eca9c6544294, it captures 20260405-c53ca64).

However, explicitly truncating in the script would make the intent clearer and more maintainable:

♻️ Proposed refactor
     "script": [
         "try {",
         "    $release = $page | ConvertFrom-Json",
         "    $date = Get-Date $release.updated_at -Format 'yyyyMMdd'",
-        "    $commit = $release.target_commitish",
+        "    $commit = $release.target_commitish.Substring(0, 7)",
         "    return \"$date-$commit\"",
         "",
         "}catch {",
         "    return ''",
         "}"
     ],
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/wezterm-nightly.json` around lines 44 - 58, The script should
explicitly truncate the full SHA stored in target_commitish to the first 7
characters to make intent clear: when building the version string in the
checkver block use the $release.target_commitish value (currently assigned to
$commit) but replace/substring it to the first 7 chars before returning (so the
returned string is "$date-<7charCommit>"). Update the assignment/return that
references $commit (in the try block) to use the truncated form to match the
regex and improve readability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@bucket/wezterm-nightly.json`:
- Around line 44-58: The script should explicitly truncate the full SHA stored
in target_commitish to the first 7 characters to make intent clear: when
building the version string in the checkver block use the
$release.target_commitish value (currently assigned to $commit) but
replace/substring it to the first 7 chars before returning (so the returned
string is "$date-<7charCommit>"). Update the assignment/return that references
$commit (in the try block) to use the truncated form to match the regex and
improve readability.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc3641e6-3055-4dd2-9b73-e7ba8b9ba966

📥 Commits

Reviewing files that changed from the base of the PR and between 2b14368 and fb2049a.

📒 Files selected for processing (1)
  • bucket/wezterm-nightly.json

@ycookiey
Copy link
Copy Markdown
Author

ycookiey commented Apr 6, 2026

Closing per #2785.

@ycookiey ycookiey closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: wezterm-nightly is not automatically updated (missing checkver/autoupdate)

2 participants