wezterm-nightly: Add checkver/autoupdate, bump to 20260405-c53ca64#2786
wezterm-nightly: Add checkver/autoupdate, bump to 20260405-c53ca64#2786ycookiey wants to merge 1 commit intoScoopInstaller:masterfrom
Conversation
WalkthroughUpdated the wezterm-nightly manifest to enable automatic version checking and updates. Changed the static version string to a dated format, added a hash for integrity verification, and introduced checkver and autoupdate configurations that query GitHub's nightly releases API. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds automated version checking and autoupdate support for wezterm-nightly so Excavator/Scoop can keep the manifest current again, and bumps the manifest to the latest nightly build referenced in the PR.
Changes:
- Bump
wezterm-nightlyversion to20260405-c53ca64and update the nightly ZIP SHA256. - Add
checkverusing the GitHub Releases API (updated_at+target_commitish) following the established nightly pattern. - Add
autoupdatesocheckver -u/ Excavator can rewrite the manifest as new nightlies are published.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/wezterm-nightly.json (1)
44-58: Refactor suggestion: Consider truncating commit hash explicitly for clarity.The current implementation works correctly—
target_commitishreturns the full 40-character SHA, and the regex(?<version>^\d{8}-[0-9a-f]{7})implicitly extracts the first 7 characters when matching (e.g., from20260405-c53ca64c33d1658602b9a3aaa412eca9c6544294, it captures20260405-c53ca64).However, explicitly truncating in the script would make the intent clearer and more maintainable:
♻️ Proposed refactor
"script": [ "try {", " $release = $page | ConvertFrom-Json", " $date = Get-Date $release.updated_at -Format 'yyyyMMdd'", - " $commit = $release.target_commitish", + " $commit = $release.target_commitish.Substring(0, 7)", " return \"$date-$commit\"", "", "}catch {", " return ''", "}" ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/wezterm-nightly.json` around lines 44 - 58, The script should explicitly truncate the full SHA stored in target_commitish to the first 7 characters to make intent clear: when building the version string in the checkver block use the $release.target_commitish value (currently assigned to $commit) but replace/substring it to the first 7 chars before returning (so the returned string is "$date-<7charCommit>"). Update the assignment/return that references $commit (in the try block) to use the truncated form to match the regex and improve readability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@bucket/wezterm-nightly.json`:
- Around line 44-58: The script should explicitly truncate the full SHA stored
in target_commitish to the first 7 characters to make intent clear: when
building the version string in the checkver block use the
$release.target_commitish value (currently assigned to $commit) but
replace/substring it to the first 7 chars before returning (so the returned
string is "$date-<7charCommit>"). Update the assignment/return that references
$commit (in the try block) to use the truncated form to match the regex and
improve readability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cc3641e6-3055-4dd2-9b73-e7ba8b9ba966
📒 Files selected for processing (1)
bucket/wezterm-nightly.json
|
Closing per #2785. |
The wezterm-nightly manifest lacks checkver/autoupdate, so it has not been automatically updated since 2025-12-20 (#2646). This adds script-based checkver using the GitHub API
updated_atfield, mirroring the goneovim-nightly pattern (#725, #2541).Closes #2785
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Chores