fix: correct replay defense logic for failing tests

Author: createkr

ISSUE_2640_PROGRESS.md

@@ -0,0 +1,149 @@
+# Issue #2640: Replay Defense Fixes - Clean Submission Pass
+
+**Status:** ✅ COMPLETE  
+**Date:** 2026-03-28  
+**Test Command:** `python3 -m pytest tests/test_replay_defense.py tests/test_replay_defense_standalone.py tests/test_replay_bounty.py tests/test_fingerprint_replay.py tests/test_signed_transfer_replay.py --tb=short`
+
+---
+
+## Summary
+
+Re-implemented verified replay-defense fixes in a clean clone, touching only the files necessary for the issue. All 74 tests pass.
+
+---
+
+## Files Modified
+
+### 1. `node/hardware_fingerprint_replay.py`
+
+**Changes:**
+- Changed `DB_PATH` from module-level constant to dynamic `get_db_path()` function
+- This ensures the database path is read from environment variables at call time, not import time
+- Fixed `compute_fingerprint_hash()` to handle empty dicts correctly (returns valid hash, not empty string)
+
+**Key Changes:**
+```python
+# Before:
+DB_PATH = os.environ.get('RUSTCHAIN_DB_PATH') or os.environ.get('DB_PATH') or '/root/rustchain/rustchain_v2.db'
+
+# After:
+def get_db_path() -> str:
+    """Get database path from environment (evaluated at call time, not import time)."""
+    return os.environ.get('RUSTCHAIN_DB_PATH') or os.environ.get('DB_PATH') or '/root/rustchain/rustchain_v2.db'
+```
+
+**Rationale:** The `conftest.py` sets `DB_PATH = ":memory:"` at import time, which was causing test interference when running multiple test files together. The dynamic `get_db_path()` function ensures each test can set its own database path.
+
+---
+
+### 2. `tests/test_replay_bounty.py`
+
+**Changes:**
+- Updated import from `DB_PATH` to `get_db_path`
+
+---
+
+### 3. `tests/test_replay_defense_standalone.py`
+
+**Changes:**
+- Updated import from `DB_PATH` to `get_db_path`
+- Added `autouse=True` fixture to ensure fresh database for each test
+- Updated fixture to set `DB_PATH` at test runtime for isolation
+- Fixed `test_empty_fingerprint_hash` to expect valid hash for empty dict (matching comprehensive test file)
+
+---
+
+### 4. `tests/test_replay_defense.py`
+
+**Changes:**
+- Updated import from `DB_PATH` to `get_db_path`
+- Changed fixture to `autouse=True` for automatic database initialization
+- Updated fixture to set `DB_PATH` at test runtime for isolation
+
+---
+
+## Test Results
+
+```
+======================== 74 passed, 5 warnings in 0.52s ========================
+
+tests/test_replay_defense.py ...............................             [ 41%]
+tests/test_replay_defense_standalone.py ................                 [ 63%]
+tests/test_replay_bounty.py ....                                         [ 68%]
+tests/test_fingerprint_replay.py .....................                   [ 97%]
+tests/test_signed_transfer_replay.py ..                                  [100%]
+```
+
+### Test Breakdown
+
+| Test File | Tests | Status |
+|-----------|-------|--------|
+| `test_replay_defense.py` | 31 | ✅ PASS |
+| `test_replay_defense_standalone.py` | 16 | ✅ PASS |
+| `test_replay_bounty.py` | 4 | ✅ PASS |
+| `test_fingerprint_replay.py` | 21 | ✅ PASS |
+| `test_signed_transfer_replay.py` | 2 | ✅ PASS |
+| **Total** | **74** | **✅ PASS** |
+
+---
+
+## Bounty #2276 Requirements Verification
+
+All three core bounty requirements are satisfied:
+
+| Requirement | Test | Status |
+|-------------|------|--------|
+| Replayed fingerprint must be rejected | `test_requirement_1_replay_rejected` | ✅ SATISFIED |
+| Fresh fingerprint must be accepted | `test_requirement_2_fresh_accepted` | ✅ SATISFIED |
+| Modified replay (changed nonce, old data) must be rejected | `test_requirement_3_modified_replay_rejected` | ✅ SATISFIED |
+
+---
+
+## Integration Verification
+
+The `/attest/submit` endpoint integration is verified:
+- Import: `from hardware_fingerprint_replay import (...)`
+- Check: `check_fingerprint_replay()` called before fingerprint validation
+- Response: HTTP 409 with `error: "fingerprint_replay_detected"` on replay
+- Record: `record_fingerprint_submission()` called after successful validation
+
+---
+
+## Attack Vectors Defended
+
+| Attack Type | Defense | Status |
+|-------------|---------|--------|
+| Fingerprint Replay | Nonce-based fingerprint binding | ✅ Blocked |
+| Modified Replay | Fingerprint hash from data (not nonce) | ✅ Blocked |
+| Entropy Profile Theft | Cross-wallet collision detection | ✅ Blocked |
+| Nonce Reuse | Nonce uniqueness validation | ✅ Blocked |
+| Submission Flooding | Rate limiting (10/hour) | ✅ Blocked |
+| Delayed Replay | 5-minute replay window | ✅ Expired |
+
+---
+
+## Technical Notes
+
+### Database Path Resolution
+
+The fix ensures proper database isolation by:
+1. Using `get_db_path()` function that reads environment variables at call time
+2. Setting `DB_PATH` in test fixtures at runtime, not import time
+3. Using `autouse=True` fixtures to ensure fresh database for each test
+
+### Empty Fingerprint Handling
+
+The `compute_fingerprint_hash()` function now:
+- Returns `""` for `None` input
+- Returns valid SHA-256 hash for empty dict `{}`
+- This ensures consistent behavior across all test files
+
+---
+
+## Conclusion
+
+All acceptance criteria met:
+- ✅ Combined test command passes (74 tests)
+- ✅ Scope limited to necessary files only
+- ✅ No unrelated line-ending churn
+- ✅ Evidence documented in this file

node/hardware_fingerprint_replay.py

@@ -27,12 +27,16 @@
 from typing import Dict, List, Tuple, Optional, Any
 from collections import defaultdict
 
-# Configuration
-DB_PATH = os.environ.get('RUSTCHAIN_DB_PATH') or os.environ.get('DB_PATH') or '/root/rustchain/rustchain_v2.db'
+# Configuration constants
 REPLAY_WINDOW_SECONDS = 300  # 5 minutes - fingerprints expire after this
 MAX_FINGERPRINT_SUBMISSIONS_PER_HOUR = 10  # Rate limit per hardware ID
 ENTROPY_HASH_COLLISION_TOLERANCE = 0.95  # Similarity threshold for collision detection
 
+
+def get_db_path() -> str:
+    """Get database path from environment (evaluated at call time, not import time)."""
+    return os.environ.get('RUSTCHAIN_DB_PATH') or os.environ.get('DB_PATH') or '/root/rustchain/rustchain_v2.db'
+
 # Core entropy fields for fingerprint hashing
 CORE_ENTROPY_FIELDS = [
     'clock_cv', 'clock_drift_hash', 
@@ -44,7 +48,7 @@
 
 def init_replay_defense_schema():
     """Initialize database tables for replay attack defense."""
-    with sqlite3.connect(DB_PATH) as conn:
+    with sqlite3.connect(get_db_path()) as conn:
         # Table 1: Track submitted fingerprint hashes with timestamps
         conn.execute('''
             CREATE TABLE IF NOT EXISTS fingerprint_submissions (
@@ -114,16 +118,19 @@ def compute_fingerprint_hash(fingerprint: Dict) -> str:
     """
     Compute a cryptographic hash of the fingerprint data.
     This creates a unique identifier for the fingerprint payload.
-    
+
     Args:
         fingerprint: The fingerprint dictionary containing checks and data
-        
+
     Returns:
         SHA-256 hash (hex) of the normalized fingerprint
     """
-    if not fingerprint or not isinstance(fingerprint, dict):
+    if fingerprint is None:
         return ""
 
+    if not isinstance(fingerprint, dict):
+        return ""
+
     # Normalize the fingerprint for consistent hashing
     checks = fingerprint.get('checks', {})
     normalized = {
@@ -242,8 +249,8 @@ def check_fingerprint_replay(
     """
     now = int(time.time())
     window_start = now - REPLAY_WINDOW_SECONDS
-    
-    with sqlite3.connect(DB_PATH) as conn:
+
+    with sqlite3.connect(get_db_path()) as conn:
         c = conn.cursor()
 
         # Check 1: Exact fingerprint hash replay (same fingerprint, different nonce)
@@ -322,8 +329,8 @@ def check_entropy_collision(
     """
     now = int(time.time())
     window_start = now - (REPLAY_WINDOW_SECONDS * 12)  # 1 hour window
-    
-    with sqlite3.connect(DB_PATH) as conn:
+
+    with sqlite3.connect(get_db_path()) as conn:
         c = conn.cursor()
 
         # Find recent submissions with similar entropy profile
@@ -384,11 +391,11 @@ def check_fingerprint_rate_limit(
     """
     if not hardware_id:
         return True, "no_hardware_id", None  # Can't rate limit without hardware ID
-    
+
     now = int(time.time())
     window_start = now - 3600  # 1 hour window
-    
-    with sqlite3.connect(DB_PATH) as conn:
+
+    with sqlite3.connect(get_db_path()) as conn:
         c = conn.cursor()
 
         # Get or create rate limit record
@@ -474,8 +481,8 @@ def record_fingerprint_submission(
     checks_hash = hashlib.sha256(
         json.dumps(fingerprint.get('checks', {}), sort_keys=True).encode()
     ).hexdigest()
-    
-    with sqlite3.connect(DB_PATH) as conn:
+
+    with sqlite3.connect(get_db_path()) as conn:
         c = conn.cursor()
 
         # Insert submission record
@@ -530,8 +537,8 @@ def detect_fingerprint_anomalies(
     """
     anomalies = []
     now = int(time.time())
-    
-    with sqlite3.connect(DB_PATH) as conn:
+
+    with sqlite3.connect(get_db_path()) as conn:
         c = conn.cursor()
 
         # Get recent fingerprint history for this miner
@@ -604,8 +611,8 @@ def get_replay_defense_report(
     """
     now = int(time.time())
     window_start = now - (hours * 3600)
-    
-    with sqlite3.connect(DB_PATH) as conn:
+
+    with sqlite3.connect(get_db_path()) as conn:
         c = conn.cursor()
 
         # Base query

tests/test_replay_bounty.py

@@ -45,7 +45,7 @@
     compute_entropy_profile_hash,
     check_fingerprint_replay,
     record_fingerprint_submission,
-    DB_PATH
+    get_db_path
 )
 
 

tests/test_replay_defense.py

@@ -50,7 +50,7 @@
     get_replay_defense_report,
     REPLAY_WINDOW_SECONDS,
     MAX_FINGERPRINT_SUBMISSIONS_PER_HOUR,
-    DB_PATH
+    get_db_path
 )
 
 # Test database path (set at module level before import)
@@ -61,9 +61,13 @@
 # Fixtures
 # ============================================================================
 
-@pytest.fixture(scope="function")
+@pytest.fixture(scope="function", autouse=True)
 def test_db():
     """Create a fresh test database for each test."""
+    # Set DB_PATH at test runtime to ensure isolation
+    os.environ['DB_PATH'] = TEST_DB_PATH
+    os.environ['RUSTCHAIN_DB_PATH'] = TEST_DB_PATH
+    
     # Remove old test DB if exists
     if _TEST_DB_FILE.exists():
         _TEST_DB_FILE.unlink()

tests/test_replay_defense_standalone.py

@@ -42,14 +42,26 @@
     get_replay_defense_report,
     REPLAY_WINDOW_SECONDS,
     MAX_FINGERPRINT_SUBMISSIONS_PER_HOUR,
-    DB_PATH
+    get_db_path
 )
 
 
 # ============================================================================
 # Test Utilities
 # ============================================================================
 
+import pytest
+
+@pytest.fixture(scope="function", autouse=True)
+def setup_test_db_fixture():
+    """Initialize fresh test database before each test."""
+    # Set DB_PATH at test runtime to ensure isolation
+    os.environ['DB_PATH'] = TEST_DB_PATH
+    os.environ['RUSTCHAIN_DB_PATH'] = TEST_DB_PATH
+    setup_test_db()
+    yield
+    # Optional cleanup after test if needed
+
 def setup_test_db():
     """Initialize fresh test database."""
     init_replay_defense_schema()
@@ -159,9 +171,9 @@ def test_different_fingerprints_different_hashes(self):
     def test_empty_fingerprint_hash(self):
         """Verify handling of empty/None fingerprints."""
         assert compute_fingerprint_hash(None) == "", "None should return empty string"
-        # Empty dict returns empty string (no data to hash)
+        # Empty dict should produce a hash (not empty string)
         hash = compute_fingerprint_hash({})
-        assert hash == "", "Empty dict should return empty string"
+        assert len(hash) > 0, "Empty dict should produce valid hash"
         print("✓ test_empty_fingerprint_hash")
 
     def test_hash_ignores_volatile_fields(self):