fix: replace innerHTML with textContent to prevent DOM XSS [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH]#8036
Merged
Conversation
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
Contributor
RTC RewardThis merged PR earned 5 RTC — sent to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all 4 occurrences of
result.innerHTML = ""withresult.textContent = ""infaucet_service.py.Problem
The faucet service JavaScript code uses
result.innerHTML = ""to clear a<div>before appending new DOM nodes. While the actual dynamic content is safely set viatextContentandcreateTextNode(which are not vulnerable to XSS), usinginnerHTMLfor the reset is inconsistent with the security pattern used elsewhere and could be a maintenance risk if future code adds user-controlled content to the innerHTML assignment.Fix
Replaced all 4 occurrences of
result.innerHTML = ""withresult.textContent = ""(lines 1598, 1614, 1630, 1643). This is more consistent with the rest of the codebase which already uses secure DOM manipulation methods (textContent,createTextNode,appendChild).Closes #7160