Skip to content

fix: replace innerHTML with DOM node construction to prevent XSS (Closes #7137) #8037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace innerHTML with DOM node construction to prevent XSS (Closes #7137) #8037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tools/bcos-badge-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,14 +732,14 @@ <h1>BCOS Badge Generator</h1>
img.alt = `BCOS Badge for ${certId}`;

img.onload = () => {
previewArea.innerHTML = '';
previewArea.replaceChildren();
previewArea.appendChild(img);
resolve();
};

img.onerror = () => {
// For demo purposes, show a placeholder if endpoint is unavailable
previewArea.innerHTML = '';
previewArea.replaceChildren();
const container = document.createElement('div');
container.style.textAlign = 'left';

Expand Down Expand Up @@ -808,7 +808,11 @@ <h1>BCOS Badge Generator</h1>
function setLoading(loading) {
if (loading) {
generateBtn.disabled = true;
generateBtn.innerHTML = '<span class="spinner"></span>Generating...';
generateBtn.replaceChildren();
const spinner = document.createElement('span');
spinner.className = 'spinner';
generateBtn.appendChild(spinner);
generateBtn.appendChild(document.createTextNode('Generating...'));
} else {
generateBtn.disabled = false;
generateBtn.textContent = 'Generate Badge';
Expand All @@ -821,7 +825,7 @@ <h1>BCOS Badge Generator</h1>
currentStyle = 'flat';
styleBtns.forEach(b => b.classList.remove('active'));
styleBtns[0].classList.add('active');
previewArea.innerHTML = '';
previewArea.replaceChildren();
const span = document.createElement('span');
span.className = 'preview-placeholder';
span.textContent = 'Enter a Certificate ID and click "Generate Preview" to see your badge';
Expand Down
Loading