Skip to content

fix: Windows miner path error 0x80070003 when running fingerprint_checks.py [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #8059

Open
waterWang wants to merge 3 commits into
Scottcjn:mainfrom
waterWang:fix/windows-miner-path-8031
Open

fix: Windows miner path error 0x80070003 when running fingerprint_checks.py [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH]#8059
waterWang wants to merge 3 commits into
Scottcjn:mainfrom
waterWang:fix/windows-miner-path-8031

Conversation

@waterWang

Copy link
Copy Markdown
Contributor

Problem

Running python3 miners/fingerprint_checks.py from the repo root on Windows fails with error 0x80070003 (ERROR_PATH_NOT_FOUND) because the file is at miners/windows/fingerprint_checks.py, not miners/fingerprint_checks.py.

Fix

  1. New miners/fingerprint_checks.py — a platform-detecting wrapper that auto-detects the OS (linux/windows/macos) and delegates to the correct platform-specific implementation. Users can now run:

    python3 miners/fingerprint_checks.py

    from the repo root on any supported platform.

  2. New miners/__init__.py — makes miners a proper Python package so the wrapper can import platform-specific modules.

  3. Updated all three platform miners (linux, windows, macos) — they now try the miners.EXACT_PLATFORM.fingerprint_checks import path first (works from any working directory), falling back to the direct fingerprint_checks import (works when running from the platform subdirectory).

Fixes #8031

@waterWang
waterWang requested a review from Scottcjn as a code owner July 25, 2026 17:38
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/M PR: 51-200 lines labels Jul 25, 2026
@JHON12091986

Copy link
Copy Markdown
Contributor

He probado el fix localmente en Windows 11 y funciona correctamente. El error 0x80070003 ya no aparece al ejecutar python miners/fingerprint_checks.py. Todos los 6 checks de fingerprint pasaron exitosamente. Gracias por la solución rápida, @waterWang.

@waterWang waterWang left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger-ci

@waterWang

Copy link
Copy Markdown
Contributor Author

Hi Scottcjn, friendly ping on this one. The fix addresses the Windows miner path error (0x80070003) when running fingerprint_checks.py. CI is green, ready for review when you have a moment. Thanks!

@waterWang

Copy link
Copy Markdown
Contributor Author

hi @Scottcjn, friendly ping on this PR. The community test confirmed the fix works on Windows 11 (see JHON12091986's comment). Could you take a look when you have time? Thanks!

@JHON12091986

Copy link
Copy Markdown
Contributor

@waterWang @Scottcjn

I have tested this PR on Windows 11 and can confirm it resolves the 0x80070003 error.

Test Results:

  • All 6 fingerprint checks pass successfully
  • Path resolution works correctly from all tested directories
  • No regression observed on existing functionality

Additional Testing Done:
I verified the wrapper works from different working directories:

  • From repo root: python3 miners/fingerprint_checks.py
  • From miners/ directory: python3 fingerprint_checks.py
  • From parent directory: python3 miners/fingerprint_checks.py

@Scottcjn, this PR appears ready to merge. The community test confirms it works on Windows.

Suggestion:
After merging, consider adding a small section in CONTRIBUTING.md about platform-specific miner paths to prevent future regressions.

Great work @waterWang.

My wallet: JH0NS (for bounty tracking)

wangye and others added 3 commits July 28, 2026 20:19
…cks.py

Add a platform-detecting wrapper at miners/fingerprint_checks.py that
auto-detects the OS (linux/windows/macos) and delegates to the correct
platform-specific implementation, so users can run:

    python3 miners/fingerprint_checks.py

from the repo root on any supported platform.

Also update all three platform miners (linux, windows, macos) to try
the miners.EXACT_PLATFORM.fingerprint_checks import path first (works
from any working directory), falling back to the direct fingerprint_checks
import (works when running from the platform subdirectory).

Fixes Scottcjn#8031
@waterWang
waterWang force-pushed the fix/windows-miner-path-8031 branch from 8093287 to 8ad9ef1 Compare July 28, 2026 12:21
@waterWang

Copy link
Copy Markdown
Contributor Author

trigger-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/M PR: 51-200 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Windows miner path issue

2 participants