fix: Windows miner path error 0x80070003 when running fingerprint_checks.py [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #8059
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
|
He probado el fix localmente en Windows 11 y funciona correctamente. El error 0x80070003 ya no aparece al ejecutar python miners/fingerprint_checks.py. Todos los 6 checks de fingerprint pasaron exitosamente. Gracias por la solución rápida, @waterWang. |
|
Hi Scottcjn, friendly ping on this one. The fix addresses the Windows miner path error (0x80070003) when running fingerprint_checks.py. CI is green, ready for review when you have a moment. Thanks! |
|
hi @Scottcjn, friendly ping on this PR. The community test confirmed the fix works on Windows 11 (see JHON12091986's comment). Could you take a look when you have time? Thanks! |
|
I have tested this PR on Windows 11 and can confirm it resolves the 0x80070003 error. Test Results:
Additional Testing Done:
@Scottcjn, this PR appears ready to merge. The community test confirms it works on Windows. Suggestion: Great work @waterWang. My wallet: JH0NS (for bounty tracking) |
…cks.py
Add a platform-detecting wrapper at miners/fingerprint_checks.py that
auto-detects the OS (linux/windows/macos) and delegates to the correct
platform-specific implementation, so users can run:
python3 miners/fingerprint_checks.py
from the repo root on any supported platform.
Also update all three platform miners (linux, windows, macos) to try
the miners.EXACT_PLATFORM.fingerprint_checks import path first (works
from any working directory), falling back to the direct fingerprint_checks
import (works when running from the platform subdirectory).
Fixes Scottcjn#8031
8093287 to
8ad9ef1
Compare
|
trigger-ci |
Problem
Running
python3 miners/fingerprint_checks.pyfrom the repo root on Windows fails with error 0x80070003 (ERROR_PATH_NOT_FOUND) because the file is atminers/windows/fingerprint_checks.py, notminers/fingerprint_checks.py.Fix
New
miners/fingerprint_checks.py— a platform-detecting wrapper that auto-detects the OS (linux/windows/macos) and delegates to the correct platform-specific implementation. Users can now run:from the repo root on any supported platform.
New
miners/__init__.py— makesminersa proper Python package so the wrapper can import platform-specific modules.Updated all three platform miners (
linux,windows,macos) — they now try theminers.EXACT_PLATFORM.fingerprint_checksimport path first (works from any working directory), falling back to the directfingerprint_checksimport (works when running from the platform subdirectory).Fixes #8031