From c15b848a66f7f7e65ca2bb931eae19bf7bd43083 Mon Sep 17 00:00:00 2001 From: Scott Date: Mon, 27 Jul 2026 10:50:01 -0500 Subject: [PATCH] Remove the --exclude-mail flag that makes the link checker exit 2 The link-check job has not checked a link since 22 July. Every run on main fails the same way: error: unexpected argument '--exclude-mail' found Process completed with exit code 2 lychee removed --exclude-mail; mail links are now skipped by default and --include-mail opts back in. The action resolves to a lychee version that rejects the flag, so the binary exits before it reads a single file. This is the failure mode worth naming: the job did not report broken links, it reported that it could not start, and a red check for an unparseable argument looks much like a red check for a genuinely broken link. Three runs on main failed this way and the workflow kept being treated as if it were guarding something. Verified after removing it: a run with the same args minus this flag checks 2,261 links and reports 0 errors. Contributors have since opened several PRs against this bounty proposing new duplicate link-check workflows. None of them needed to. The existing workflow was one flag away from working. Signed-off-by: Scott --- .github/workflows/lychee.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/lychee.yml b/.github/workflows/lychee.yml index 59f40b662..0d6361819 100644 --- a/.github/workflows/lychee.yml +++ b/.github/workflows/lychee.yml @@ -23,7 +23,6 @@ jobs: --exclude "https?://(twitter|x)\.com" --exclude "https://github.com/Scottcjn/Rustchain/actions" --exclude "https?://(www\.)?(linkedin|facebook|instagram|tiktok)" - --exclude-mail -- './**/*.md' './**/*.html' env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}