Skip to content

fix: remove deprecated --exclude-mail flag from lychee config [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #8080

Open
waterWang wants to merge 1 commit into
Scottcjn:mainfrom
waterWang:fix-remove-exclude-mail-8077
Open

fix: remove deprecated --exclude-mail flag from lychee config [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH]#8080
waterWang wants to merge 1 commit into
Scottcjn:mainfrom
waterWang:fix-remove-exclude-mail-8077

Conversation

@waterWang

Copy link
Copy Markdown
Contributor

Fixes #8077

The --exclude-mail flag was removed in a newer version of lychee, causing the link checker to fail with "unexpected argument '--exclude-mail' found" on every run since July 22. Mail links are skipped by default now, so the flag is no longer needed.

This is a one-line fix: simply remove the --exclude-mail argument from the lychee args.

@waterWang
waterWang requested a review from Scottcjn as a code owner July 27, 2026 19:15
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) ci size/XS PR: 1-10 lines labels Jul 27, 2026
@Scottcjn

Copy link
Copy Markdown
Owner

Verified and this is correct.

Current lychee has no --exclude-mail option. lychee-bin/src/config/mod.rs only defines include_mail, which returns self.include_mail.unwrap_or(false), and the filter is uri.is_mail() && !self.include_mail. There are upstream tests literally named test_exclude_mail_by_default. So mail links are skipped by default and the flag that used to request that is gone.

That means the removal is behaviour-preserving as well as necessary: nothing starts getting checked that was not being checked before.

Single line, single purpose, no test impact. Looks good to me.

One scheduling note: #8082 also deletes this same line as part of an unrelated docs change, so the two conflict in .github/workflows/lychee.yml. I would land this one first and let #8082 rebase, since this is the change that is actually about the flag.

waterWang pushed a commit to waterWang/Rustchain-vintage-fix that referenced this pull request Jul 28, 2026
Per maintainer review: the --exclude rules hide broken links instead of
fixing them, and the --exclude-mail removal collides with PR Scottcjn#8080.
This PR is now the single-line docs correction only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) ci size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants