Skip to content

docs: fix WHAT_IF emission row — no halving, fixed 1.5 RTC/epoch [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #8082

Open
waterWang wants to merge 4 commits into
Scottcjn:mainfrom
waterWang:fix-docs-8063
Open

docs: fix WHAT_IF emission row — no halving, fixed 1.5 RTC/epoch [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH]#8082
waterWang wants to merge 4 commits into
Scottcjn:mainfrom
waterWang:fix-docs-8063

Conversation

@waterWang

Copy link
Copy Markdown
Contributor

Fixes #8063

Line 38 of docs/WHAT_IF_RTC_FUNDAMENTALS.md incorrectly referenced halvings lowering the emission. The README Tokenomics section, RIP-0004, and PER_BLOCK_RTC in the node code all say emission is a fixed 1.5 RTC per epoch with no halving. This fix aligns the row with the actual emission model.

@github-actions

Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/XS PR: 1-10 lines labels Jul 27, 2026
@waterWang
waterWang requested a review from Scottcjn as a code owner July 27, 2026 21:15
@github-actions github-actions Bot added the ci label Jul 27, 2026
@Scottcjn

Copy link
Copy Markdown
Owner

The docs change is correct. The workflow change bundled with it is not, and it collides with #8080.

On the emission row. Confirmed against the authoritative sources rather than the description:

  • node/sophia_elya_service.py:36 has PER_BLOCK_RTC = 1.5 # Fixed per block, and there is no halving logic anywhere in node/ (the only halving hit in the tree is BOUNTY_HALF_LIFE, which is bounty pricing, not emission).
  • README.md:423 already says | Halving | None | and line 425 spells out the fixed 1.5 RTC per epoch.
  • docs/WHITEPAPER.md:594 already reads "Fixed emission (no halving)".
  • node/tokenomics_route.py:21 has TOTAL_SUPPLY_RTC = 8_388_608 # 2^23, consensus-enforced.

So the old cell was also a dangling cross-reference: it pointed at "README section Tokenomics" for halvings that the README no longer documents. This moves toward the code. Good change.

One follow-up worth filing: docs/tokenomics_v1.md lines 11 and 28 still claim halving every 2 years. That is now the last place in the doc set that contradicts the node.

On the lychee changes. These are unrelated to the stated purpose of the PR and I would rather they were not in it.

The 8 new --exclude rules are not fixing broken links, they are hiding them. I resolved each one:

404  https://rustchain.org/whitepaper
404  https://rustchain.org/install
404  https://rustchain.org/manifesto
404  https://rustchain.org/green
404  https://scottcjn.github.io/elyan-labs-site/
404  https://bottube.ai/settings/api

Those are the project's own pages, linked from its own docs, and they really are dead. Excluding them makes the link checker green while the docs stay broken for readers. The right fix is to repair the links or the site, not to mute the checker.

Removing --exclude-mail is correct on its own (current lychee has no such flag, only include_mail, which defaults to false), but that exact one-line removal is already #8080, which is a clean single-purpose PR. As it stands these two PRs both delete the same line and will conflict; I confirmed git merge-tree reports a conflict in .github/workflows/lychee.yml. Whichever lands first, the other needs a rebase.

Suggestion: drop .github/workflows/lychee.yml from this PR so it is just the one-line docs correction, let #8080 handle the flag, and open a separate issue or PR for the dead rustchain.org and bottube.ai links so they get fixed rather than suppressed.

Per maintainer review: the --exclude rules hide broken links instead of
fixing them, and the --exclude-mail removal collides with PR Scottcjn#8080.
This PR is now the single-line docs correction only.
@waterWang

Copy link
Copy Markdown
Contributor Author

Per review feedback: dropped the lychee.yml changes from this PR. The docs fix (no halving, fixed 1.5 RTC/epoch) is now the only change. The --exclude-mail removal is handled by #8080, and the broken-link exclusions are dropped — they should be fixed rather than suppressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) ci documentation Improvements or additions to documentation size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants