implement best-practices for better-sqlite3

Author: ScriptRaccoon

databases/catdat/scripts/deduce-category-implications.ts

@@ -15,7 +15,7 @@ export function deduce_category_implications(db: Database) {
  * Clears all deduced implications. This is done as a first step.
  */
 function clear_deduced_category_implications(db: Database) {
-	db.exec(`DELETE FROM category_implications WHERE is_deduced = TRUE`)
+	db.prepare(`DELETE FROM category_implications WHERE is_deduced = TRUE`).run()
 }
 
 /**

databases/catdat/scripts/deduce-category-properties.ts

@@ -195,9 +195,7 @@ function get_properties_dict(db: Database) {
  * This runs before the deduction starts.
  */
 function delete_deduced_category_properties(db: Database) {
-	db.exec(`
-		DELETE FROM category_property_assignments
-		WHERE is_deduced = TRUE`)
+	db.prepare(`DELETE FROM category_property_assignments WHERE is_deduced = TRUE`).run()
 }
 
 /**
@@ -285,7 +283,7 @@ function deduce_satisfied_category_properties(
 		`
 
 		try {
-			db.prepare(insert_sql).run(...values)
+			db.prepare(insert_sql).run(values)
 		} catch (err) {
 			if (err instanceof SqliteError) {
 				if (err.code.startsWith('SQLITE_CONSTRAINT')) {
@@ -395,7 +393,7 @@ function deduce_unsatisfied_category_properties(
 		`
 
 		try {
-			db.prepare(insert_query).run(...values)
+			db.prepare(insert_query).run(values)
 		} catch (err) {
 			if (err instanceof SqliteError) {
 				if (err.code.startsWith('SQLITE_CONSTRAINT')) {
@@ -461,7 +459,7 @@ function deduce_dual_category_properties(
 			(category_id, property_id, is_satisfied, reason, is_deduced)
 		VALUES ${value_fragments.join(',\n')}`
 
-		db.prepare(insert_query).run(...values)
+		db.prepare(insert_query).run(values)
 
 		console.info(
 			`Deduced ${new_satisfied.size} satisfied properties by duality for ${category.id}`,
@@ -486,7 +484,7 @@ function deduce_dual_category_properties(
 			(category_id, property_id, is_satisfied, reason, is_deduced)
 		VALUES ${value_fragments.join(',\n')}`
 
-		db.prepare(insert_query).run(...values)
+		db.prepare(insert_query).run(values)
 
 		console.info(
 			`Deduced ${new_unsatisfied.size} unsatisfied properties by duality for ${category.id}`,

databases/catdat/scripts/deduce-functor-implications.ts

@@ -17,7 +17,7 @@ export function deduce_functor_implications(db: Database) {
  * Clears all deduced functor implications. This is done as a first step.
  */
 function clear_deduced_functor_implications(db: Database) {
-	db.exec(`DELETE FROM functor_implications WHERE is_deduced = TRUE`)
+	db.prepare(`DELETE FROM functor_implications WHERE is_deduced = TRUE`).run()
 }
 
 /**

databases/catdat/scripts/deduce-functor-properties.ts

@@ -204,7 +204,7 @@ function get_functor_properties_dict(db: Database) {
  * This runs before the deduction starts.
  */
 function delete_deduced_functor_properties(db: Database) {
-	db.exec('DELETE FROM functor_property_assignments WHERE is_deduced = TRUE')
+	db.prepare('DELETE FROM functor_property_assignments WHERE is_deduced = TRUE').run()
 }
 
 /**
@@ -283,7 +283,7 @@ function deduce_satisfied_functor_properties(
 			${value_fragments.join(',\n')}
 		`
 
-		db.prepare(insert_sql).run(...values)
+		db.prepare(insert_sql).run(values)
 	}
 
 	console.info(
@@ -371,7 +371,7 @@ function deduce_unsatisfied_functor_properties(
 			VALUES
 			${value_fragments.join(',\n')}`
 
-		db.prepare(insert_query).run(...values)
+		db.prepare(insert_query).run(values)
 	}
 
 	console.info(

databases/catdat/scripts/deduce.ts

@@ -12,7 +12,7 @@ import { get_client } from './shared'
 function deduce() {
 	const db = get_client()
 
-	db.exec('PRAGMA foreign_keys = ON')
+	db.pragma('foreign_keys = ON')
 
 	deduce_category_implications(db)
 	deduce_category_properties(db)

databases/catdat/scripts/setup.ts

@@ -11,7 +11,7 @@ function setup() {
 	console.info('\n--- Setup CatDat database ---')
 
 	const db = get_client()
-	db.exec('PRAGMA foreign_keys = ON')
+	db.pragma('foreign_keys = ON')
 
 	const schema_folder = path.join(process.cwd(), 'databases', 'catdat', 'schema')
 

src/lib/server/db.catdat.ts

@@ -7,7 +7,7 @@ const db_path = join(process.cwd(), 'databases', 'catdat', 'catdat.db')
 /**
  * Database client for the CatDat database holding all mathematical knowledge
  */
-const db = new Database(db_path, { readonly: true })
+const db = new Database(db_path, { readonly: true, fileMustExist: true })
 
 /**
  * Small wrapper around db.prepare.all to handle errors,