allow properties to be ignored by redundancy check script

Author: ScriptRaccoon

databases/catdat/schema/004_category-properties.sql

@@ -28,6 +28,8 @@ CREATE TABLE category_property_assignments (
     reason TEXT NOT NULL CHECK (length(reason) > 0),
     is_deduced INTEGER NOT NULL DEFAULT FALSE
         CHECK (is_deduced in (TRUE, FALSE)),
+    check_redundancy INTEGER NOT NULL DEFAULT TRUE
+        CHECK (check_redundancy in (TRUE, FALSE)),
     UNIQUE (category_id, property_id),
     FOREIGN KEY (category_id) REFERENCES categories (id) ON DELETE CASCADE,
     FOREIGN KEY (property_id) REFERENCES category_properties (id) ON DELETE CASCADE

databases/catdat/scripts/categories.utils.ts

@@ -230,3 +230,27 @@ export function get_next_implication_for_contradiction(
 	}
 	return null
 }
+
+/**
+ * Returns a dictionary mapping a category to the set of its assigned
+ * properties (satisfied or unsatisfied) that should not be checked
+ * by the redundancy check script.
+ */
+export function get_ignored_redundant_properties(db: Database) {
+	const rows = db
+		.prepare(
+			`SELECT category_id, property_id
+			FROM category_property_assignments
+			WHERE check_redundancy = FALSE`,
+		)
+		.all() as { category_id: string; property_id: string }[]
+
+	const grouped: Record<string, Set<string>> = {}
+
+	for (const row of rows) {
+		grouped[row.category_id] ??= new Set()
+		grouped[row.category_id].add(row.property_id)
+	}
+
+	return grouped
+}

databases/catdat/scripts/redundancies.ts

@@ -2,6 +2,7 @@ import { get_client } from './shared'
 import {
 	get_all_assignments,
 	get_categories,
+	get_ignored_redundant_properties,
 	get_next_implication,
 	get_next_implication_for_contradiction,
 	get_normalized_category_implications,
@@ -30,13 +31,15 @@ function check_redundant_category_property_assignments() {
 	const implications = get_normalized_category_implications(db)
 	const categories = get_categories(db)
 	const assignments = get_all_assignments(db, categories)
+	const ignore_dict = get_ignored_redundant_properties(db)
 
 	let redundancy_count = 0
 
 	for (const category of categories) {
 		const redundant_satisfied_property = get_redundant_satisfied_property(
 			assignments[category.id].satisfied.non_deduced,
 			implications,
+			ignore_dict[category.id],
 		)
 
 		if (redundant_satisfied_property) {
@@ -56,6 +59,7 @@ function check_redundant_category_property_assignments() {
 			all_satisfied_properties,
 			assignments[category.id].unsatisfied.non_deduced,
 			implications,
+			ignore_dict[category.id],
 		)
 
 		if (redundant_unsatisfied_property) {
@@ -104,8 +108,10 @@ function get_deduced_satisfied_properties(
 function get_redundant_satisfied_property(
 	satisfied_properties: Set<string>,
 	implications: NormalizedCategoryImplication[],
+	ignored: Set<string> = new Set(),
 ) {
 	for (const p of [...satisfied_properties]) {
+		if (ignored.has(p)) continue
 		satisfied_properties.delete(p)
 		const deduced_properties = get_deduced_satisfied_properties(
 			satisfied_properties,
@@ -161,8 +167,10 @@ function get_redundant_unsatisfied_property(
 	satisfied_properties: Set<string>,
 	unsatisfied_properties: Set<string>,
 	implications: NormalizedCategoryImplication[],
+	ignored: Set<string> = new Set(),
 ) {
 	for (const p of [...unsatisfied_properties]) {
+		if (ignored.has(p)) continue
 		unsatisfied_properties.delete(p)
 		const deduced_properties = get_deduced_unsatisfied_properties(
 			satisfied_properties,