refactor redundancy utility

Author: ScriptRaccoon

databases/catdat/scripts/redundancies.ts

@@ -13,7 +13,7 @@ import {
 	type StructureMeta,
 } from './utils/deduction'
 import { get_functors, get_normalized_functor_implications } from './utils/functors'
-import { StructureType } from './config'
+import type { StructureType } from './config'
 
 const db = get_client()
 
@@ -45,7 +45,7 @@ function check_redundant_property_assignments(type: StructureType) {
 	const structures: StructureMeta[] =
 		type === 'category' ? get_categories(db) : get_functors(db)
 
-	const assignments = get_property_assignments_by_deduction(db, structures, type)
+	const assignments = get_property_assignments_by_deduction(db, type)
 	const ignore_dict = get_ignored_redundant_assignments(type)
 
 	const ignore_count = Object.keys(ignore_dict).reduce(

databases/catdat/scripts/utils/deduction.ts

@@ -140,11 +140,7 @@ export function get_property_assignments(
  * grouped by structure, value (satisfied / unsatisfied), and deduced status.
  * We exclude undecidable properties here.
  */
-export function get_property_assignments_by_deduction(
-	db: Database,
-	structures: { id: string }[],
-	type: StructureType,
-) {
+export function get_property_assignments_by_deduction(db: Database, type: StructureType) {
 	const rows = db
 		.prepare<
 			[string],
@@ -173,15 +169,14 @@ export function get_property_assignments_by_deduction(
 		}
 	> = {}
 
-	for (const structure of structures) {
-		grouped[structure.id] = {
+	for (const row of rows) {
+		const { property_id, structure_id, is_satisfied, is_deduced } = row
+
+		grouped[structure_id] ??= {
 			satisfied: { non_deduced: new Set(), deduced: new Set() },
 			unsatisfied: { non_deduced: new Set(), deduced: new Set() },
 		}
-	}
 
-	for (const row of rows) {
-		const { property_id, structure_id, is_satisfied, is_deduced } = row
 		grouped[structure_id][is_satisfied ? 'satisfied' : 'unsatisfied'][
 			is_deduced ? 'deduced' : 'non_deduced'
 		].add(property_id)