Enforce that the trivial category has no unsatisfied properties#100
Merged
ScriptRaccoon merged 2 commits intomainfrom Apr 17, 2026
Merged
Enforce that the trivial category has no unsatisfied properties#100ScriptRaccoon merged 2 commits intomainfrom
ScriptRaccoon merged 2 commits intomainfrom
Conversation
ScriptRaccoon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR adds a test (included in
pnpm db:test) that confirms that the trivial category has no unsatisfied properties. Together with the existing test that all properties are decided for it, this means that every property is satisfied for the trivial category. This enforces that all properties in the database are "positive". For example, it prevents that "infinite" is added (we use "finite" instead). This was already documented in the contribution guidelines, but now it's properly enforced.There is a small chance that I regret this decision at some point, but then the easy fix is to add the trivial category to the core categories (currently: Set, Top, Ab) for which every property is checked (satisfied or not).