Fix update script#159
Merged
Merged
Conversation
Owner
Author
|
@dschepler In case you also had issues with the development server, they should be fixed with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The development server stopped showing data changes after the database was updated with
pnpm db:update. The cause was #138, and specifically 1772e4b (removal of migrations). In this change, the script was modified to also delete the local database file before rebuilding it from scratch.I assume this breaks the database connection in the development server, which is why it no longer reacts to changes.
This PR fixes this issue by excluding the setup step from the update command. A downside is that the setup command now has to be run manually by maintainers whenever the schema changes, with no automatic mechanism in place (since migrations have been removed*). For now, I think this is acceptable, as only a small number of people are actively working on CatDat and they can be informed when schema changes occur.
*Maybe I should bring them back.