test: canonicalize storage suite profile roots

Author: ScriptedAlchemy

tests/storage_suite/branch_drift_test.rs

@@ -57,14 +57,7 @@ impl Drop for HomeEnvGuard {
 }
 
 fn canonical_temp_path(path: &Path) -> PathBuf {
-    #[cfg(windows)]
-    {
-        path.to_path_buf()
-    }
-    #[cfg(not(windows))]
-    {
-        path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
-    }
+    path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
 }
 
 fn git_output(project: &Path, args: &[&str]) -> Output {

tests/storage_suite/migrate_inventory_test.rs

@@ -16,14 +16,7 @@ use tracedecay::migrate::manifest::{
 };
 
 fn canonical_temp_path(path: &Path) -> PathBuf {
-    #[cfg(windows)]
-    {
-        path.to_path_buf()
-    }
-    #[cfg(not(windows))]
-    {
-        path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
-    }
+    path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
 }
 
 fn with_env_vars<T>(vars: &[(&str, Option<&Path>)], f: impl FnOnce() -> T) -> T {

tests/storage_suite/migration_manifest_test.rs

@@ -43,14 +43,7 @@ fn manifest_for(protocol: MigrationProtocol, migration_id: &str) -> MigrationMan
 }
 
 fn canonical_temp_path(path: &Path) -> PathBuf {
-    #[cfg(windows)]
-    {
-        path.to_path_buf()
-    }
-    #[cfg(not(windows))]
-    {
-        path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
-    }
+    path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
 }
 
 #[cfg(unix)]

tests/storage_suite/profile_storage_migration_test.rs

@@ -70,14 +70,7 @@ impl Drop for HomeEnvGuard {
 }
 
 fn canonical_temp_path(path: &Path) -> PathBuf {
-    #[cfg(windows)]
-    {
-        path.to_path_buf()
-    }
-    #[cfg(not(windows))]
-    {
-        path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
-    }
+    path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
 }
 
 fn portable_relpath(path: &str) -> String {

tests/storage_suite/storage_resolver_test.rs

@@ -77,14 +77,7 @@ fn write_enrollment(root: &Path) {
 }
 
 fn canonical_temp_path(path: &Path) -> PathBuf {
-    #[cfg(windows)]
-    {
-        path.to_path_buf()
-    }
-    #[cfg(not(windows))]
-    {
-        path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
-    }
+    path.canonicalize().unwrap_or_else(|_| path.to_path_buf())
 }
 
 fn test_home(dir: &TempDir) -> PathBuf {