fix(lcm): default transcript reads to all providers

Author: ScriptedAlchemy

src/agents/hermes/templates/plugin_init.py

@@ -296,6 +296,18 @@ def _resolve_auxiliary_client(agent=None):
     "tracedecay_lcm_preflight",
 ))
 
+STANDARD_HERMES_LCM_PROVIDER = "cursor"
+
+LCM_PROVIDER_LOCAL_TOOL_NAMES = frozenset((
+    "tracedecay_lcm_compress",
+    "tracedecay_lcm_describe",
+    "tracedecay_lcm_doctor",
+    "tracedecay_lcm_expand",
+    "tracedecay_lcm_expand_query",
+    "tracedecay_lcm_preflight",
+    "tracedecay_lcm_session_boundary",
+))
+
 # Direct duplicates of the memory provider's own tool surface
 # (fact_store / fact_feedback / memory_status). Skipped at register() time
 # when tracedecay is the active memory.provider so the same store is not
@@ -1858,7 +1870,9 @@ def _synthesize_expand_query_payload(retrieval, agent=None, **kwargs):
 def _handle_lcm_expand_query(args, **kwargs) -> str:
     kwargs = dict(kwargs)
     agent = kwargs.pop("agent", None)
-    retrieval = call_tracedecay_json("tracedecay_lcm_expand_query", args or {}, **kwargs)
+    args = dict(args or {})
+    args.setdefault("provider", STANDARD_HERMES_LCM_PROVIDER)
+    retrieval = call_tracedecay_json("tracedecay_lcm_expand_query", args, **kwargs)
     payload = _synthesize_expand_query_payload(retrieval, agent=agent, **kwargs)
     return json.dumps(payload)
 
@@ -2219,6 +2233,7 @@ def _report_compression_boundary(self, session_id, bound_session_id, kwargs):
             return
         args = _storage_args(self.project_root, self.hermes_home)
         args.update({
+            "provider": STANDARD_HERMES_LCM_PROVIDER,
             "session_id": session_id,
             "old_session_id": old_session_id,
             "boundary_reason": boundary_reason,
@@ -2261,6 +2276,7 @@ def _preflight_probe(self, messages, current_tokens=None, **kwargs):
             )
         )
         args.update({
+            "provider": STANDARD_HERMES_LCM_PROVIDER,
             "session_id": self.active_session_id,
             "messages": messages,
             "current_tokens": current_tokens,
@@ -2469,6 +2485,8 @@ def handle_tool_call(self, name, arguments=None, **kwargs) -> str:
         storage_args = _storage_args(self.project_root, self.hermes_home)
         for key, value in storage_args.items():
             tool_args.setdefault(key, value)
+        if tracedecay_name in LCM_PROVIDER_LOCAL_TOOL_NAMES:
+            tool_args.setdefault("provider", STANDARD_HERMES_LCM_PROVIDER)
         if tracedecay_name == "tracedecay_lcm_compress" and self.project_root:
             tool_args.setdefault("response_handle_project_root", self.project_root)
         if native_name in ("lcm_status", "lcm_doctor"):
@@ -2485,6 +2503,7 @@ def handle_tool_call(self, name, arguments=None, **kwargs) -> str:
     def expand_query(self, prompt, query=None, node_ids=None, **kwargs):
         kwargs = dict(kwargs)
         args = self._tool_args(kwargs.pop("session_id", None))
+        args["provider"] = STANDARD_HERMES_LCM_PROVIDER
         args["prompt"] = prompt
         if query is not None:
             args["query"] = query
@@ -2903,6 +2922,7 @@ def _compress_to_result(self, messages, current_tokens=None, focus_topic=None, *
             )
         )
         args.update({
+            "provider": STANDARD_HERMES_LCM_PROVIDER,
             "messages": messages,
             "current_tokens": current_tokens,
             "focus_topic": focus_topic,
@@ -3199,7 +3219,11 @@ def sync_turn(self, user_content, assistant_content, *, session_id="", messages=
                 role = str(entry.get("role") or "user")
                 entry["id"] = f"tracedecay_sync_{batch_id}_{timestamp_ns}_{idx}_{role}"
         args = _storage_args(self.project_root, self.hermes_home)
-        args.update({"session_id": sid, "messages": turn_messages})
+        args.update({
+            "provider": STANDARD_HERMES_LCM_PROVIDER,
+            "session_id": sid,
+            "messages": turn_messages,
+        })
         try:
             tools.call_tracedecay_tool(
                 "tracedecay_lcm_preflight",

src/mcp/tools/definitions.rs

@@ -2392,7 +2392,7 @@ fn def_lcm_status() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id to inspect (default: cursor)."
+                    "description": "Optional provider id. Omit or use 'all' to inspect all providers."
                 },
                 "session_id": {
                     "type": "string",
@@ -2420,7 +2420,7 @@ fn def_lcm_doctor() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id to inspect (default: cursor)."
+                    "description": "Specific provider id to inspect or repair. Required; 'all' is not accepted for this lifecycle tool."
                 },
                 "session_id": {
                     "type": "string",
@@ -2463,7 +2463,8 @@ fn def_lcm_doctor() -> ToolDefinition {
                 "storage_scope": lcm_storage_scope_schema(),
                 "hermes_home": lcm_hermes_home_schema()
             },
-            "allOf": lcm_storage_scope_requires_hermes_home()
+            "allOf": lcm_storage_scope_requires_hermes_home(),
+            "required": ["provider"]
         }),
     )
 }
@@ -2478,7 +2479,7 @@ fn def_lcm_load_session() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id, default cursor."
+                    "description": "Optional provider id. Omit or use 'all' to load messages for this session id across all providers."
                 },
                 "session_id": {
                     "type": "string",
@@ -2616,7 +2617,7 @@ fn def_lcm_describe() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id, default cursor."
+                    "description": "Specific provider id. Required because describe targets are provider-local."
                 },
                 "session_id": {
                     "type": "string",
@@ -2644,7 +2645,7 @@ fn def_lcm_describe() -> ToolDefinition {
                 "hermes_home": lcm_hermes_home_schema()
             },
             "allOf": lcm_storage_scope_requires_hermes_home(),
-            "required": ["session_id"]
+            "required": ["provider", "session_id"]
         }),
     )
 }
@@ -2659,7 +2660,7 @@ fn def_lcm_expand() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id, default cursor."
+                    "description": "Specific provider id. Required because expansion targets are provider-local."
                 },
                 "session_id": {
                     "type": "string",
@@ -2714,7 +2715,7 @@ fn def_lcm_expand() -> ToolDefinition {
                 "hermes_home": lcm_hermes_home_schema()
             },
             "allOf": lcm_storage_scope_requires_hermes_home(),
-            "required": ["session_id", "target"]
+            "required": ["provider", "session_id", "target"]
         }),
     )
 }
@@ -2729,7 +2730,7 @@ fn def_lcm_expand_query() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id, default cursor."
+                    "description": "Specific provider id. Required because retrieval context is provider-local."
                 },
                 "session_id": {
                     "type": "string",
@@ -2775,7 +2776,7 @@ fn def_lcm_expand_query() -> ToolDefinition {
                 "hermes_home": lcm_hermes_home_schema()
             },
             "allOf": lcm_storage_scope_requires_hermes_home(),
-            "required": ["session_id", "prompt"]
+            "required": ["provider", "session_id", "prompt"]
         }),
     )
 }
@@ -2790,7 +2791,7 @@ fn def_lcm_preflight() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id, default cursor."
+                    "description": "Specific provider id. Required for compression lifecycle operations."
                 },
                 "session_id": {
                     "type": "string",
@@ -2865,7 +2866,8 @@ fn def_lcm_preflight() -> ToolDefinition {
                 "storage_scope": lcm_storage_scope_schema(),
                 "hermes_home": lcm_hermes_home_schema()
             },
-            "allOf": lcm_storage_scope_requires_hermes_home()
+            "allOf": lcm_storage_scope_requires_hermes_home(),
+            "required": ["provider", "session_id"]
         }),
     )
 }
@@ -2880,7 +2882,7 @@ fn def_lcm_compress() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id, default cursor."
+                    "description": "Specific provider id. Required for compression lifecycle operations."
                 },
                 "session_id": {
                     "type": "string",
@@ -2978,7 +2980,7 @@ fn def_lcm_compress() -> ToolDefinition {
                 "hermes_home": lcm_hermes_home_schema()
             },
             "allOf": lcm_storage_scope_requires_hermes_home(),
-            "required": ["session_id"]
+            "required": ["provider", "session_id"]
         }),
     )
 }
@@ -2993,7 +2995,7 @@ fn def_lcm_session_boundary() -> ToolDefinition {
             "properties": {
                 "provider": {
                     "type": "string",
-                    "description": "Provider id, default cursor."
+                    "description": "Specific provider id. Required for compression lifecycle operations."
                 },
                 "session_id": {
                     "type": "string",
@@ -3015,7 +3017,7 @@ fn def_lcm_session_boundary() -> ToolDefinition {
                 "hermes_home": lcm_hermes_home_schema()
             },
             "allOf": lcm_storage_scope_requires_hermes_home(),
-            "required": ["session_id"]
+            "required": ["provider", "session_id"]
         }),
     )
 }

src/mcp/tools/handlers/session.rs

@@ -811,8 +811,18 @@ fn timestamp_argument_error(name: &str) -> TraceDecayError {
     ))
 }
 
-fn provider_arg(args: &Value) -> &str {
-    string_arg(args, "provider").unwrap_or("cursor")
+fn provider_or_all_arg(args: &Value) -> &str {
+    optional_search_provider_arg(args).unwrap_or("all")
+}
+
+fn required_specific_provider_arg(args: &Value) -> Result<&str> {
+    match string_arg(args, "provider") {
+        Some("all") => Err(argument_error(
+            "provider must name a specific provider for this tool",
+        )),
+        Some(provider) => Ok(provider),
+        None => Err(argument_error("provider is required for this tool")),
+    }
 }
 
 fn optional_search_provider_arg(args: &Value) -> Option<&str> {
@@ -1270,15 +1280,10 @@ fn parse_lcm_scope(args: &Value) -> Result<LcmScope> {
     }
 }
 
-fn lcm_grep_provider_arg(args: &Value, scope: LcmScope) -> &str {
+fn lcm_grep_provider_arg(args: &Value) -> &str {
     if let Some(provider) = optional_search_provider_arg(args) {
         return provider;
     }
-    if matches!(scope, LcmScope::Current | LcmScope::Session)
-        && string_arg(args, "provider").is_none()
-    {
-        return provider_arg(args);
-    }
     "all"
 }
 
@@ -1507,7 +1512,7 @@ pub(super) async fn handle_lcm_status(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = provider_or_all_arg(&args);
     let session_id = string_arg(&args, "session_id");
     let deep = bool_arg(&args, "deep")?.unwrap_or(false);
     let gc_config = lcm_gc_config(&args)?;
@@ -1534,7 +1539,7 @@ pub(super) async fn handle_lcm_doctor(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = required_specific_provider_arg(&args)?;
     let session_id = string_arg(&args, "session_id");
     let mode = lcm_doctor_mode(&args)?;
     let apply = args.get("apply").and_then(Value::as_bool).unwrap_or(false);
@@ -1629,7 +1634,7 @@ pub(super) async fn handle_lcm_load_session(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = provider_or_all_arg(&args);
     let session_id = required_string_arg(&args, "session_id")?;
     let (content_slice, content_limit_clamped_from) = lcm_load_content_slice(&args)?;
     let storage = lcm_open_storage_ro!(context, &args);
@@ -1682,7 +1687,7 @@ pub(super) async fn handle_lcm_grep(
     // Validate scope before opening storage so argument errors are reported
     // even when the sessions DB does not exist yet.
     let scope = parse_lcm_scope(&args)?;
-    let provider = lcm_grep_provider_arg(&args, scope);
+    let provider = lcm_grep_provider_arg(&args);
     let storage = lcm_open_storage_ro!(context, &args);
     let hits = storage
         .db
@@ -1721,7 +1726,7 @@ pub(super) async fn handle_lcm_describe(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = required_specific_provider_arg(&args)?;
     let session_id = required_string_arg(&args, "session_id")?;
     // Validate target before opening storage so argument errors are reported
     // even when the sessions DB does not exist yet.
@@ -1751,7 +1756,7 @@ pub(super) async fn handle_lcm_expand(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = required_specific_provider_arg(&args)?;
     let session_id = required_string_arg(&args, "session_id")?;
     let target = parse_lcm_expand_target(&args)?;
     let storage = lcm_open_storage_ro!(context, &args);
@@ -1782,7 +1787,7 @@ pub(super) async fn handle_lcm_expand_query(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = required_specific_provider_arg(&args)?;
     let session_id = required_string_arg(&args, "session_id")?;
     let prompt = required_string_arg(&args, "prompt")?;
     let max_results =
@@ -1835,7 +1840,7 @@ pub(super) async fn handle_lcm_session_boundary(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = required_specific_provider_arg(&args)?;
     let session_id = required_string_arg(&args, "session_id")?;
     let storage = lcm_open_storage!(context, &args);
     let response = storage
@@ -1866,7 +1871,7 @@ pub(super) async fn handle_lcm_preflight(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = required_specific_provider_arg(&args)?;
     let session_id = required_string_arg(&args, "session_id")?;
     let storage = lcm_open_storage!(context, &args);
     let response = storage
@@ -1907,7 +1912,7 @@ pub(super) async fn handle_lcm_compress(
     context: LcmHandlerContext<'_>,
     args: Value,
 ) -> Result<ToolResult> {
-    let provider = provider_arg(&args);
+    let provider = required_specific_provider_arg(&args)?;
     let session_id = required_string_arg(&args, "session_id")?;
     let response_handle_root = lcm_response_handle_root(context.project_root, &args);
     let storage = lcm_open_storage!(context, &args);

src/sessions/lcm/query.rs

@@ -99,6 +99,7 @@ pub(crate) async fn load_session(
     let limit = clamp_limit(request.limit);
     let fetch_limit = limit.saturating_add(1);
     let mut values = vec![
+        Value::Text(request.provider.clone()),
         Value::Text(request.provider.clone()),
         Value::Text(request.session_id.clone()),
         Value::Integer(request.after_store_id.unwrap_or(0)),
@@ -124,7 +125,7 @@ pub(crate) async fn load_session(
                 timestamp, content, content_hash, storage_kind, payload_ref,
                 snippet_text, legacy_source, legacy_truncated, metadata_json
          FROM lcm_raw_messages
-         WHERE provider = ?
+         WHERE (? = 'all' OR provider = ?)
            AND session_id = ?
            AND store_id > ?
            {role_clause}

tests/hermes_suite/lcm_bridge.rs

@@ -1231,6 +1231,7 @@ args_index = argv.index("--args")
 args = json.loads(argv[args_index + 1])
 assert args == {
     "project_root": "/tmp/project",
+    "provider": "cursor",
     "fresh_tail_count": 64,
     "leaf_chunk_tokens": 20000,
     "dynamic_leaf_chunk_enabled": False,
@@ -1315,6 +1316,7 @@ assert argv[1:6] == ["tool", "--project", "/tmp/project", "tracedecay_lcm_sessio
 args = json.loads(argv[argv.index("--args") + 1])
 assert args == {
     "project_root": "/tmp/project",
+    "provider": "cursor",
     "session_id": "session-b",
     "old_session_id": "session-c",
     "boundary_reason": "compression",
@@ -1423,6 +1425,7 @@ else:
 assert args == {
     "project_root": "/tmp/project",
     "response_handle_project_root": "/tmp/project",
+    "provider": "cursor",
     "fresh_tail_count": 64,
     "leaf_chunk_tokens": 20000,
     "dynamic_leaf_chunk_enabled": False,