[codex] Speed up MCP tool CLI coverage test - #240
Merged
Conversation
|
Renames the in-process render check to say what it actually covers and adds a single binary invocation asserting the CLI prints exactly the rendered help, so tool-name resolution and help dispatch stay covered end-to-end. Also uses strip_prefix for the short-name helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ScriptedAlchemy
marked this pull request as ready for review
July 3, 2026 03:21
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterCI runstool_skill_coverage_test::every_mcp_tool_is_invocable_via_the_clias the slowest consistent Windows test: median 3.2765s, average 3.359s, max 3.852stracedecay tool <name> --helprendering into the library and reused it from the CLIValidation
cargo fmt --all -- --checkgit diff --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo nextest run --profile ci --locked --test agent_suite tool_skill_coverage_test::every_mcp_tool_is_invocable_via_the_cli(test body 0.020s locally)cargo nextest run --profile ci --locked --test core_cli_suite cli_help_test::tool_name_help_still_prints_tool_schemacargo test --locked mcp::tools::tests::tool_result_constructors_keep_internal_analytics_explicit