fix: harden session routing and nested worktrees - #485
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c097fb820c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [workspace] | ||
| exclude = [".worktrees", ".codex-worktrees"] |
There was a problem hiding this comment.
Keep package include in the package table
Placing [workspace] here changes the scope of the subsequent include = [...], so Cargo interprets it as the unsupported workspace.include key and the package loses its explicit whitelist. As a result, cargo package omits the gitignored dashboard dist assets that the whitelist deliberately ships, leaving published builds to attempt an npm rebuild or fail when npm/assets are unavailable; move the workspace table below the package-specific keys.
Useful? React with 👍 / 👎.
| } | ||
| } | ||
| ProjectMembership::NoMatch => {} | ||
| ProjectMembership::Unknown => return None, |
There was a problem hiding this comment.
Let a definitive Cline path match override unknown paths
When Cline metadata contains both a path that definitively belongs to project_root and another stale or network-backed path whose Git lookup times out, this branch returns None and discards the already-recorded match. Such multi-path metadata previously used any matching path, so a consistently inaccessible auxiliary path can now prevent a valid task from ever being ingested; accumulate Unknown and defer only when no path produced Match.
Useful? React with 👍 / 👎.
Summary
Validation