fix: delete_by_* for unique keys with 1 column#3059
Open
sefidel wants to merge 1 commit intoSeaQL:masterfrom
Open
fix: delete_by_* for unique keys with 1 column#3059sefidel wants to merge 1 commit intoSeaQL:masterfrom
sefidel wants to merge 1 commit intoSeaQL:masterfrom
Conversation
Member
|
Yes, we should add a test. @tyt2y3 Why did we skip the case where column len = 1 at first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Fixes the issue where the documentation specifies usage of
delete_by_*with one-column unique keys, butsea-orm-macrosonly generated them for unique keys wherecolumns > 1.Bug Fixes
delete_by_*functions for unique keys with one columnp.s. Should we have a test case for
delete_by_*functions intests/active_model_ex_tests.rs?