Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
df2eb2a
EOS-23396: [k8s] Added module name parameter to mini provisioner fram…
vimalraghwani20 Aug 12, 2021
21f8188
[EOS-21417] : [K8S] Adopt to Kubernetes (Logging) (#1103)
pranavPawar07 Aug 26, 2021
3c16dd2
Fixed code check format on K8S branch (#1239)
vimalraghwani20 Sep 8, 2021
f95ba04
EOS-23396: [K8S] Config file changes (#1102)
vimalraghwani20 Sep 8, 2021
a5b034f
[K8S] EOS-24813:S3: workaround step for bgdelete producer (#1238)
sachitanands Sep 8, 2021
d2fe211
EOS-23396: Fixed FI enable in authserver (#1243)
vimalraghwani20 Sep 8, 2021
e3aa8bc
Changes for k8s branch to adhere with latest function (#1248)
pranavPawar07 Sep 9, 2021
b98aa66
EOS-24038: Generate log directories based on machine id for all modul…
vimalraghwani20 Sep 13, 2021
6d1afcf
[EOS-24037] Config changes on k8s branch (#1251)
nileshgovande Sep 13, 2021
78b6b7f
Config path changed to /etc/cortx for auth and s3 in startup script (…
SaumitraK531 Sep 14, 2021
8d21870
[EOS-24037] : [K8s] Generate log directories based on container id fo…
pranavPawar07 Sep 15, 2021
0907222
Changes for container based s3_setup
Sep 15, 2021
9172d78
Changes for syntax errors
Sep 15, 2021
b02abda
Fixes to run s3_setup in container
Sep 16, 2021
cc7849e
EOS-24042:S3: Mapping of new provisioner confstore keys to s3 confsto…
sachitanands Sep 16, 2021
ee8160d
fixes for mini-prov (#1274)
sachitanands Sep 16, 2021
0be4509
EOS-24655 - Kubernetes haproxy micro-provisioner code changes. (#1261)
shahidSTX Sep 17, 2021
e623b28
added setup type to postinstall, prepare phase (#1280)
pranavPawar07 Sep 17, 2021
4965187
Fixes in package check
Sep 17, 2021
b60f119
EOS23401- Handling for --service parameter in s3 provisioning (#1282)
shalakadharap Sep 17, 2021
72db908
Services Fix (#1287)
sachitanands Sep 17, 2021
d7c84d4
HAproxy port numbers should be read from confstore. (#1277)
shahidSTX Sep 17, 2021
c71d2d6
slapd fixes (#1288)
sachitanands Sep 17, 2021
c4522d8
EOS-24974: Fix auth base config path in startauth.sh argument (#1292)
t7ko-seagate Sep 20, 2021
5bc0113
Remove hardcoded ldaphost string from ldapaccountaction class (#1294)
sachitanands Sep 20, 2021
e0eb8af
Fix for K8s to K8 for setup_type
Sep 20, 2021
2863f69
EOS-24857: Initial K8s automation - single node deployment (#1290)
t7ko-seagate Sep 20, 2021
7857339
K8: python fix for mini-provisioner issue (#1296)
sachitanands Sep 20, 2021
54a1283
EOS-24939: Use file lock to prevent two s3_setup process writing same…
t7ko-seagate Sep 20, 2021
17db273
Logger fix
Sep 20, 2021
e14d76e
Deployment fixes
Sep 20, 2021
f3f729b
Run-break-fix session on s3_setup
t7ko-seagate Sep 20, 2021
51aa5c9
One more missing literal_eval
t7ko-seagate Sep 20, 2021
47c1bac
Fix pem file path for default certificate
t7ko-seagate Sep 20, 2021
a44e371
EOS-22334 k8s: Auth startup dependency removal - SPIKE (#1302)
abhilekh268 Sep 21, 2021
fa861e5
EOS-24974: specify proper path for BG consumer (#1304)
t7ko-seagate Sep 21, 2021
2f46786
HAproxy should read config path from confstore. (#1303)
shahidSTX Sep 21, 2021
5590324
Sagregated log dir for producer/consumer (#1306)
nileshgovande Sep 21, 2021
a840687
HAProxy cfg changes
Sep 21, 2021
c39e02e
EOS-24974: Changes for machine ID.
t7ko-seagate Sep 20, 2021
5c2a468
Fixes in port and purge is enabled back
Sep 22, 2021
1bdd512
EOS-24974: Use machine-id in log path for haproxy log file (#1311)
t7ko-seagate Sep 24, 2021
ee993dd
Changes to template files to accomodate array entries in new format (…
shahidSTX Sep 27, 2021
f614945
[MINI PROV] : Fixed deployment logger bug (#1313)
pranavPawar07 Sep 27, 2021
7ff1a0e
Changes to keys to align with confstore (#1317)
shahidSTX Sep 29, 2021
ab4cae3
BG consumer endpoint updation changes (#1319)
SaumitraK531 Sep 29, 2021
edf093f
Fixes for Provisioner (#1327)
vimalraghwani20 Sep 30, 2021
2d9732a
Read path from confstore and remove hard-coding (#1333)
shahidSTX Oct 1, 2021
2ed92bd
Softlink changes (#1336)
shahidSTX Oct 1, 2021
fd67288
EOS-24396: tailf changes in s3_start script (#1337)
vimalraghwani20 Oct 1, 2021
e4f6e7e
S3_start fixes (#1338)
vimalraghwani20 Oct 1, 2021
038e700
fixed get_confkey() (#1339)
vimalraghwani20 Oct 1, 2021
e24f802
Fixed the error in s3_setup (#1340)
vimalraghwani20 Oct 1, 2021
aec4a0b
EOS-24396: Added logging in service start (#1343)
vimalraghwani20 Oct 4, 2021
fd50846
EOS-24355: Implementation for the log rotate config files for K8S (#1…
vimalraghwani20 Oct 12, 2021
20b9bf0
EOS-24355: Fixed the symbolic link issue for haproxy and s3server (#1…
vimalraghwani20 Oct 13, 2021
b10700c
EOS-25389 : Support bundle changes for K8S (#1387)
shahidSTX Oct 18, 2021
69577e8
Update jenkins script to pass params to support bundle script (#1400)
shahidSTX Oct 19, 2021
7868248
[EOS-24576] [F-8B] Removal of stop dependency on S3 Server Services. …
SaumitraK531 Oct 29, 2021
27262f4
EOS-25442:S3:Enable core generation for kubernetes branch (#1569)
sachitanands Oct 29, 2021
06d2952
EOS-25740: Motr retry timout should be read from constore and set in …
vimalraghwani20 Nov 2, 2021
5feec59
EOS-25798 : Fix preupgrade and postupgrade commands (#1606)
shahidSTX Nov 19, 2021
0c24632
EOS-25444: Separate out all 3rd party dependencies from the s3 rpm sp…
vimalraghwani20 Nov 23, 2021
7eb0759
build failure fixed (#1621)
vimalraghwani20 Nov 25, 2021
9e3880a
Common code for services framework (#1629)
vimalraghwani20 Nov 30, 2021
84ac7b3
EOS-26566: Search functionality based on key and value for partition…
vimalraghwani20 Dec 1, 2021
c051dfb
Mini provisioner failure fixes (#1632)
vimalraghwani20 Dec 2, 2021
2b00db0
EOS-23396: [K8S] Config file changes (#1102)
vimalraghwani20 Sep 8, 2021
efff09b
Fixes to upgrade class init def (#1634)
shahidSTX Dec 2, 2021
0f2e4fb
EOS-26780: Fixed the rebase issue (#1639)
vimalraghwani20 Dec 3, 2021
f3b9b49
EOS-26569 : logging changes to enable merge logging (#1640)
shahidSTX Dec 3, 2021
40ac36a
EOS-26573:S3: Handle consul endpoint and port values in config phase …
sachitanands Dec 6, 2021
181ba81
Fix for bug in merge file (#1641)
shahidSTX Dec 6, 2021
3d87034
EOS-26572: Service separation (#1645)
vimalraghwani20 Dec 7, 2021
041003c
EOS-26572: Service Validation fixes (#1646)
vimalraghwani20 Dec 8, 2021
95e1c90
EOS-26572: Services separation in s3_start, rename of BG services (#…
vimalraghwani20 Dec 8, 2021
9129921
EOS-26881 : Update memory limits based on setup size
shahidSTX Dec 10, 2021
5201cf8
Int conversion fix
shahidSTX Dec 10, 2021
b7e1760
Review comments addressal
shahidSTX Dec 13, 2021
ddd1c44
Fix deployment bug
shahidSTX Dec 13, 2021
b1d63c0
Fix int conversion
shahidSTX Dec 13, 2021
d2e9030
Change default size
shahidSTX Dec 13, 2021
a36c114
Merge branch 'kubernetes' into br/ms/EOS-26881-memory_limits
nileshgovande Dec 16, 2021
751a117
Merge branch 'kubernetes' into br/ms/EOS-26881-memory_limits
nileshgovande Dec 17, 2021
6685aba
Merge branch 'kubernetes' into br/ms/EOS-26881-memory_limits
nileshgovande Dec 27, 2021
48a56ed
Update branch with logger changes
shahidSTX Dec 27, 2021
61b31b7
Merge branch 'main' into br/ms/EOS-26881-memory_limits
vimalraghwani20 Jan 10, 2022
d1ce84f
Merge branch 'main' into br/ms/EOS-26881-memory_limits
vimalraghwani20 Jan 18, 2022
e8db074
Merge branch 'main' into br/ms/EOS-26881-memory_limits
kupranay Feb 2, 2022
e454828
Merge branch 'main' into br/ms/EOS-26881-memory_limits
kupranay Feb 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion s3config.release.yaml.sample
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ S3_MOTR_CONFIG: # Section for S3 Motr
S3_UNIT_SIZES_FOR_MEMORY_POOL: [16384] # Memory pool will be created for each of these unit_size with following properties
S3_MOTR_READ_POOL_INITIAL_BUFFER_COUNT: 10 # 10 blocks, the initial pool size = multiple of S3_MOTR_UNIT_SIZE
S3_MOTR_READ_POOL_EXPANDABLE_COUNT: 50 # 50 blocks, pool's expandable size, multiple of S3_MOTR_UNIT_SIZE
S3_MOTR_READ_POOL_MAX_THRESHOLD: 1048576000 # 1GB, The maximum memory threshold for the pool, multiple of S3_MOTR_UNIT_SIZE
S3_MOTR_READ_POOL_MAX_THRESHOLD: 524288000 # 500MB, The maximum memory threshold for the pool, multiple of S3_MOTR_UNIT_SIZE
S3_MOTR_READ_MEMPOOL_ZERO_BUFFER: false # Enable Motr Mempool 'zeroing' after use (like secure erase) - disabled by default
S3_MOTR_OPERATION_WAIT_PERIOD: 90 # 90 s, Maximum wait duration for sync motr operations.
S3_MOTR_FIRST_READ_SIZE: 4 # Size in MB of the First Read Request to MOTR
Expand Down
34 changes: 34 additions & 0 deletions scripts/provisioning/configcmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def __init__(self, config: str, services: str = None):
super(ConfigCmd, self).__init__(config, services)
self.setup_type = self.get_confvalue_with_defaults('CONFIG>CONFSTORE_SETUP_TYPE')
Log.info(f'Setup type : {self.setup_type}')
self.setup_size = self.get_confvalue_with_defaults('CONFIG>CONFSTORE_SETUP_SIZE')
Log.info(f'Setup type : {self.setup_size}')
self.cluster_id = self.get_confvalue_with_defaults('CONFIG>CONFSTORE_CLUSTER_ID_KEY')
Log.info(f'Cluster id : {self.cluster_id}')
self.base_config_file_path = self.get_confvalue_with_defaults('CONFIG>CONFSTORE_BASE_CONFIG_PATH')
Expand Down Expand Up @@ -157,6 +159,11 @@ def process_s3server(self):
'yaml://')
Log.info("validate s3 config files completed")

# update memory limits
Log.info("updating memory limits started")
self.update_memory_limits()
Log.info("updating memory limits complete")

Log.info("create symbolic link of FID config files started")
self.create_symbolic_link_fid()
Log.info("create symbolic link of FID config files started")
Expand Down Expand Up @@ -558,6 +565,33 @@ def update_s3_server_configs(self):
self.update_config_value("S3_CONFIG_FILE", "yaml", "CONFIG>CONFSTORE_S3_MOTR_MAX_START_TIMEOUT", "S3_MOTR_CONFIG>S3_MOTR_INIT_MAX_TIMEOUT")
Log.info("Update s3 server config file completed")

def update_memory_limits(self):
""" Update memory buffer sizes."""
Log.info("Update memory buffer sizes started")
# validate config file exists - /etc/cortx/s3/conf/s3config.yaml
configfile = self.get_confkey("S3_CONFIG_FILE").replace("/opt/seagate/cortx", self.base_config_file_path)
if path.isfile(f'{configfile}') == False:
Log.error(f'{configfile} file is not present')
raise S3PROVError(f'{configfile} file is not present')

# load config file, read required keysand modify as per size
s3configfileconfstore = S3CortxConfStore(f'yaml://{configfile}', 'update_limits')
libevent_pool_initial_size = int(s3configfileconfstore.get_config("S3_THIRDPARTY_CONFIG>S3_LIBEVENT_POOL_INITIAL_SIZE"))
Copy link
Copy Markdown
Contributor Author

@shahidSTX shahidSTX Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO : uint64 can be used instead of int.

libevent_pool_max_threshold = int(s3configfileconfstore.get_config("S3_THIRDPARTY_CONFIG>S3_LIBEVENT_POOL_MAX_THRESHOLD"))
if "small" == self.setup_size:
libevent_pool_initial_size = int(libevent_pool_initial_size / 2);
libevent_pool_max_threshold = int(libevent_pool_max_threshold / 2);
elif "medium" == self.setup_size:
libevent_pool_initial_size = int((libevent_pool_initial_size * 3) / 4);
libevent_pool_max_threshold = int((libevent_pool_max_threshold * 3) / 4);
else:
libevent_pool_initial_size = libevent_pool_initial_size
libevent_pool_max_threshold = libevent_pool_max_threshold
s3configfileconfstore.set_config("S3_THIRDPARTY_CONFIG>S3_LIBEVENT_POOL_INITIAL_SIZE", libevent_pool_initial_size, True)
s3configfileconfstore.set_config("S3_THIRDPARTY_CONFIG>S3_LIBEVENT_POOL_MAX_THRESHOLD", libevent_pool_max_threshold, True)

Log.info("Update memory buffer sizes completed")

def update_s3_bgdelete_bind_port(self, value_to_update, additional_param):
if isinstance(value_to_update, str):
value_to_update = literal_eval(value_to_update)
Expand Down
3 changes: 3 additions & 0 deletions scripts/provisioning/s3_prov_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ PREPARE:
CONFIG:
# Public keys which came from provisioner which may or may not have default values.
CONFSTORE_SETUP_TYPE: "cortx>common>setup_type" #M (Usedby : s3_deployment)
CONFSTORE_SETUP_SIZE: "cortx>common>setup_size" #O (Usedby : s3_deployment)

CONFSTORE_BASE_LOG_PATH: "cortx>common>storage>log" #M (Usedby : all)
CONFSTORE_S3_SECURITY_CERTIFICATE: "cortx>common>security>ssl_certificate" #O default - /etc/ssl/stx/stx.pem (Usedby : s3_deployment, haproxy)
#CONFSTORE_S3_STORAGE_MISC: "cortx>common>storage>misc" #O default - /var/data/cortx (Usedby : none)
Expand Down Expand Up @@ -106,6 +108,7 @@ TEST:
DEFAULT_POST_INSTALL:
DEFAULT_PREPARE:
DEFAULT_CONFIG:
CONFSTORE_SETUP_SIZE: "large"
CONFSTORE_LDAPADMIN_USER_KEY: "sgiamadmin"
CONFSTORE_S3_MOTR_MAX_UNITS_PER_REQUEST : "8"
CONFSTORE_S3_MOTR_MAX_START_TIMEOUT : "240"
Expand Down