feat: Add options to configure Seagate HDD performance mode and SSD Thermal Throttle.#49
feat: Add options to configure Seagate HDD performance mode and SSD Thermal Throttle.#49seagate-395821 wants to merge 4 commits into
Conversation
…eption Control) on informational exceptions mode page.
…eption Control) on informational exceptions mode page.
…eption Control) on informational exceptions mode page.
There was a problem hiding this comment.
Since the performance mode and thermal throttle bits are specific to Seagate SAS, can we move this to seagate_operations.h/.c files?
There was a problem hiding this comment.
Just like operations.h, these are seagate vendor unique, so we should move them to seagate_operations.c
| if ((get_Device_DriveType(device) == SCSI_DRIVE) && (is_SSD(device) == false)) | ||
| { | ||
| return NOT_SUPPORTED; | ||
| } |
There was a problem hiding this comment.
This condition check is not needed here, as we need to write the wrapper for the function "scsi_Set_ThermalThrottleEnable" something like "set_ThermalThrottleEnable" which will have same implementation like "set_Read_Look_Ahead" or "scsi_Set_Write_Cache"
| } | ||
|
|
||
| M_PARAM_RO(1) | ||
| OPENSEA_OPERATIONS_API eReturnValues scsi_Set_ThermalThrottleEnable(const tDevice* M_NONNULL device, bool thermalThrottleEnable) |
There was a problem hiding this comment.
function name should be something like "scsi_Set_ThermalThrottle" instead of "scsi_Set_ThermalThrottleEnable" and parameter should be something like "thermalThrottleEnableDisable" -> this will indicate that we can either enable or disable this feature, which is general practice and adapted for other such functions.
3 participants
[FDOPENSRCE-198] - Add options to configure Seagate HDD performance mode and SSD Thermal Throttle.